From: Saul Wold <sgw@linux.intel.com>
To: Qi.Chen@windriver.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] packagegroup-core-boot: make initscripts-functions a basic element of RDEPENDS
Date: Thu, 26 Dec 2013 09:23:43 -0800 [thread overview]
Message-ID: <52BC661F.5010403@linux.intel.com> (raw)
In-Reply-To: <d5166a224cee86b6092e82c1e564162a22668710.1387959755.git.Qi.Chen@windriver.com>
On 12/25/2013 12:36 AM, Qi.Chen@windriver.com wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> Unlike the initscripts package which is useful in SysV systems but
> not so useful in systemd systems, the initscripts-functions package
> is useful for both.
>
> For the reason stated above, this patch adds initscripts-funtions to
> the RDEPENDS of packagegroup-core-boot.
>
Why not add the RDEPENDS on the initscript-functions to the appropriate
recipes, such as distcc or others that require the contents of functions?
I understand the general value of having it installed, but if
"functions" is only required for some recipes, then let's not add it in
again if unneeded.
Sau!
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
> .../packagegroups/packagegroup-core-boot.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> index 5455899..2f60c97 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> @@ -41,6 +41,7 @@ RDEPENDS_${PN} = "\
> ${@base_contains("DISTRO_FEATURES", "sysvinit", "${SYSVINIT_SCRIPTS}", "", d)} \
> ${@base_contains("MACHINE_FEATURES", "keyboard", "${VIRTUAL-RUNTIME_keymaps}", "", d)} \
> netbase \
> + initscripts-functions \
> ${VIRTUAL-RUNTIME_login_manager} \
> ${VIRTUAL-RUNTIME_init_manager} \
> ${VIRTUAL-RUNTIME_initscripts} \
>
prev parent reply other threads:[~2013-12-26 17:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-25 8:36 [PATCH 0/2] Split the functions script into a separate package in initscripts Qi.Chen
2013-12-25 8:36 ` [PATCH 1/2] initscripts: split the functions script into a separate package Qi.Chen
2013-12-25 8:36 ` [PATCH 2/2] packagegroup-core-boot: make initscripts-functions a basic element of RDEPENDS Qi.Chen
2013-12-26 17:23 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52BC661F.5010403@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=Qi.Chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox