From: Saul Wold <sgw@linux.intel.com>
To: Corneliu Stoicescu <corneliux.stoicescu@intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V2] Modify buildstats to be merged inside buildhistory
Date: Wed, 08 Jan 2014 09:31:35 -0800 [thread overview]
Message-ID: <52CD8B77.4020805@linux.intel.com> (raw)
In-Reply-To: <1389028342-23264-1-git-send-email-corneliux.stoicescu@intel.com>
On 01/06/2014 09:12 AM, Corneliu Stoicescu wrote:
> - added buildstats inheritance inside buildhistory
> - when buildhisory is used, buildstats will be moved inside the buildhistory directory
This does not seem to have a Signed-off-by:
Please submit a v2 for review.
Thanks
Sau!
> ---
> meta/classes/buildhistory.bbclass | 3 +++
> meta/classes/buildstats.bbclass | 2 +-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/buildhistory.bbclass b/meta/classes/buildhistory.bbclass
> index e9a9c3b..54efecfe 100644
> --- a/meta/classes/buildhistory.bbclass
> +++ b/meta/classes/buildhistory.bbclass
> @@ -16,9 +16,12 @@ BUILDHISTORY_IMAGE_FILES ?= "/etc/passwd /etc/group"
> BUILDHISTORY_COMMIT ?= "0"
> BUILDHISTORY_COMMIT_AUTHOR ?= "buildhistory <buildhistory@${DISTRO}>"
> BUILDHISTORY_PUSH_REPO ?= ""
> +BUILDSTATS_BASE = "${BUILDHISTORY_DIR}/buildstats"
>
> SSTATEPOSTINSTFUNCS += "buildhistory_emit_pkghistory"
>
> +inherit buildstats
> +
> #
> # Write out metadata about this package for comparision when writing future packages
> #
> diff --git a/meta/classes/buildstats.bbclass b/meta/classes/buildstats.bbclass
> index 72fff11..c8769ae 100644
> --- a/meta/classes/buildstats.bbclass
> +++ b/meta/classes/buildstats.bbclass
> @@ -1,4 +1,4 @@
> -BUILDSTATS_BASE = "${TMPDIR}/buildstats/"
> +BUILDSTATS_BASE ??= "${TMPDIR}/buildstats/"
> BNFILE = "${BUILDSTATS_BASE}/.buildname"
> DEVFILE = "${BUILDSTATS_BASE}/.device"
>
>
next prev parent reply other threads:[~2014-01-08 17:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 17:12 [PATCH V2] Modify buildstats to be merged inside buildhistory Corneliu Stoicescu
2014-01-08 17:31 ` Saul Wold [this message]
2014-01-08 17:36 ` Richard Purdie
2014-01-09 10:46 ` Stoicescu, CorneliuX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CD8B77.4020805@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=corneliux.stoicescu@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox