Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Yue Tao <Yue.Tao@windriver.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] The status for "service --status-all" is wrong after stop avahi-daemon
Date: Tue, 28 Jan 2014 10:22:04 -0800	[thread overview]
Message-ID: <52E7F54C.5020708@linux.intel.com> (raw)
In-Reply-To: <1390788441-6563-1-git-send-email-Yue.Tao@windriver.com>

On 01/26/2014 06:07 PM, Yue Tao wrote:
> $/etc/init.d/avahi-daemon stop
> $service --status-all
> [ + ] avahi-daemon
>
> Add return value of status()
>

The short message needs to be formatted correctly:

avahi: <short log>

Also this patch is not added to the recipe file.

> Signed-off-by: Yue Tao <Yue.Tao@windriver.com>
> ---
>   .../avahi/files/add_return_value_of_status.patch   |   21 ++++++++++++++++++++
>   1 files changed, 21 insertions(+), 0 deletions(-)
>   create mode 100644 meta/recipes-connectivity/avahi/files/add_return_value_of_status.patch
>
> diff --git a/meta/recipes-connectivity/avahi/files/add_return_value_of_status.patch b/meta/recipes-connectivity/avahi/files/add_return_value_of_status.patch
> new file mode 100644
> index 0000000..db80da8
> --- /dev/null
> +++ b/meta/recipes-connectivity/avahi/files/add_return_value_of_status.patch
> @@ -0,0 +1,21 @@

No Signed-off-by: or Upstream-Status: tags here

Sau!

> +--- a/initscript/debian/avahi-daemon.in
> ++++ b/initscript/debian/avahi-daemon.in
> +@@ -36,6 +36,8 @@
> + # Authors:      <sebastien.estienne@gmail.com>
> + #
> +
> ++. /etc/init.d/functions
> ++
> + if [ -f /lib/lsb/init-functions ]
> + then
> +     . /lib/lsb/init-functions
> +@@ -153,7 +155,8 @@ d_reload() {
> + #       Function that check the status of the daemon/service.
> + #
> + d_status() {
> +-    $DAEMON -c && echo "$DESC is running" || echo "$DESC is not running"
> ++    status $DAEMON
> ++    exit $?
> + }
> +
> + case "$1" in
>


      reply	other threads:[~2014-01-28 18:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-27  2:07 [PATCH] The status for "service --status-all" is wrong after stop avahi-daemon Yue Tao
2014-01-28 18:22 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52E7F54C.5020708@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=Yue.Tao@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox