Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Ross Burton <ross.burton@intel.com>,
	 openembedded-core@lists.openembedded.org,
	 Richard Purdie <richard.purdie@linuxfoundation.org>
Subject: Re: [PATCH] pkgconfig: remove out-dated configure options and dependencies
Date: Tue, 28 Jan 2014 11:50:39 -0800	[thread overview]
Message-ID: <52E80A0F.5070003@linux.intel.com> (raw)
In-Reply-To: <1390931044-24421-1-git-send-email-ross.burton@intel.com>


Although not in this email a change to this patch seems to have removed 
the glibconfig-sysdefs.h file but not the entry in SRC_URI for the _0,28 
and _git recipes.

Not sure what happened with this, but master is not working and we 
should either revert this change or clean up the issue.

Thanks
	Sau!


On 01/28/2014 09:44 AM, Ross Burton wrote:
> 0.27 onwards uses a snapshot of glib 2 not glib 1, so drop the
> do_configure_prepend and update the internal/installed options as appropriate.
>
> Legacy scripts were removed in 0.26.
>
> Use of popt was removed in 0.28.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>   meta/recipes-devtools/pkgconfig/pkgconfig.inc |   12 ++++--------
>   1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/meta/recipes-devtools/pkgconfig/pkgconfig.inc b/meta/recipes-devtools/pkgconfig/pkgconfig.inc
> index 3e655a9..62c886f 100644
> --- a/meta/recipes-devtools/pkgconfig/pkgconfig.inc
> +++ b/meta/recipes-devtools/pkgconfig/pkgconfig.inc
> @@ -8,7 +8,7 @@ SECTION = "console/utils"
>   LICENSE = "GPLv2+"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>
> -DEPENDS = "glib-2.0 popt"
> +DEPENDS = "glib-2.0"
>   DEPENDS_class-native = ""
>   DEPENDS_class-nativesdk = ""
>
> @@ -18,15 +18,11 @@ S = "${WORKDIR}/pkg-config-${PV}/"
>
>   inherit autotools
>
> -EXTRA_OECONF = "--with-installed-glib --with-installed-popt --disable-legacy-scripts --with-internal-glib"
> -EXTRA_OECONF_class-native = "--disable-legacy-scripts --with-internal-glib"
> -EXTRA_OECONF_class-nativesdk = "--disable-legacy-scripts --with-internal-glib"
> +EXTRA_OECONF = "--without-internal-glib"
> +EXTRA_OECONF_class-native = "--with-internal-glib"
> +EXTRA_OECONF_class-nativesdk = "--with-internal-glib"
>
>   acpaths = "-I ."
> -do_configure_prepend () {
> -	mkdir --parents ${B}/glib-1.2.10
> -	install -m 0644 ${WORKDIR}/glibconfig-sysdefs.h ${B}/glib-1.2.10/
> -}
>
>   BBCLASSEXTEND = "native nativesdk"
>
>


  reply	other threads:[~2014-01-28 19:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-28 17:44 [PATCH] pkgconfig: remove out-dated configure options and dependencies Ross Burton
2014-01-28 19:50 ` Saul Wold [this message]
2014-01-28 22:34   ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52E80A0F.5070003@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox