From: "David Nyström" <david.c.nystrom@gmail.com>
To: Jonas Eriksson <jonas.eriksson@enea.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] qemu: Allow building without X11 support
Date: Wed, 29 Jan 2014 14:59:16 +0100 [thread overview]
Message-ID: <52E90934.3080900@gmail.com> (raw)
In-Reply-To: <1390988324-15471-1-git-send-email-jonas.eriksson@enea.com>
On 2014-01-29 10:38, Jonas Eriksson wrote:
> To enable the construction of minimal hypervisors based on OE, it is
> important to be able to build qemu without it requiring X support. By
> checking that the distro is built with the x11 feature before adding
> virtual/x11 to the dependencies, this is made possible.
> ---
> meta/recipes-devtools/qemu/qemu.inc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc
> index 8705dc7..76119c0 100644
> --- a/meta/recipes-devtools/qemu/qemu.inc
> +++ b/meta/recipes-devtools/qemu/qemu.inc
> @@ -1,7 +1,8 @@
> SUMMARY = "Fast open source processor emulator"
> HOMEPAGE = "http://qemu.org"
> LICENSE = "GPLv2 & LGPLv2.1"
> -DEPENDS = "glib-2.0 zlib alsa-lib virtual/libx11 pixman dtc libsdl"
> +DEPENDS = "glib-2.0 zlib alsa-lib pixman dtc libsdl \
> + ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11', '', d)}"
> DEPENDS_class-native = "zlib-native alsa-lib-native glib-2.0-native pixman-native dtc-native"
> DEPENDS_class-nativesdk = "nativesdk-zlib nativesdk-libsdl nativesdk-glib-2.0 nativesdk-pixman nativesdk-dtc"
> RDEPENDS_${PN}_class-nativesdk = "nativesdk-libsdl"
>
Reviewed-by: David Nyström <david.nystrom@enea.com>
prev parent reply other threads:[~2014-01-29 13:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 9:38 [PATCH] qemu: Allow building without X11 support Jonas Eriksson
2014-01-29 13:59 ` David Nyström [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E90934.3080900@gmail.com \
--to=david.c.nystrom@gmail.com \
--cc=jonas.eriksson@enea.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox