From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id 1F24F60155 for ; Thu, 6 Feb 2014 13:48:52 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.14.5/8.14.5) with ESMTP id s16DmkiR021386 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 6 Feb 2014 05:48:46 -0800 (PST) Received: from [128.224.146.67] (128.224.146.67) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.2.347.0; Thu, 6 Feb 2014 05:48:47 -0800 Message-ID: <52F392BC.4040608@windriver.com> Date: Thu, 6 Feb 2014 08:48:44 -0500 From: Bruce Ashfield User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Alexandre Belloni References: <1389104317-11042-1-git-send-email-alexandre.belloni@free-electrons.com> <52CC1E02.9070102@windriver.com> <52CC633C.6000404@free-electrons.com> <52CC65E5.6010003@windriver.com> <20140129131021.GH24156@piout.net> In-Reply-To: <20140129131021.GH24156@piout.net> Cc: darren.hart@intel.com, Darren Hart , openembedded-core@lists.openembedded.org Subject: Re: [PATCH] kernel: use oldnoconfig instead of yes '' | make oldconfig X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Feb 2014 13:48:52 -0000 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit On 14-01-29 08:10 AM, Alexandre Belloni wrote: > Hi Bruce, > > Any news on that ? And a update. I've been debugging some results that don't look right, so I have haven't followed up yet. I'm hopeful to get a consistent set of results by the end of the day. Bruce > > On Tue, Jan 07, 2014 at 15:39:01 -0500, Bruce Ashfield wrote : >> On 14-01-07 03:27 PM, Alexandre Belloni wrote: >>> On 07/01/2014 16:32, Bruce Ashfield wrote: >>>> On 14-01-07 09:18 AM, Alexandre Belloni wrote: >>>>> When using a defconfig, using yes '' | make oldconfig may not result in >>>>> the correct configuration being set. For example: >>>>> >>>>> $ grep USB_ETH .config >>>>> CONFIG_USB_ETH=y >>>>> CONFIG_USB_ETH_RNDIS=y >>>>> CONFIG_USB_ETH_EEM=y >>>>> $ make savedefconfig >>>>> scripts/kconfig/conf --savedefconfig=defconfig Kconfig >>>>> $ cp defconfig .config >>>>> ‘defconfig’ -> ‘.config’ >>>>> $ yes '' | make oldconfig >>>>> [...] >>>>> # >>>>> # configuration written to .config >>>>> # >>>>> $ grep USB_ETH .config >>>>> CONFIG_USB_ETH=m >>>>> CONFIG_USB_ETH_RNDIS=y >>>>> CONFIG_USB_ETH_EEM=y >>>>> >>>>> Using make olddefconfig solves that but we'll use oldnoconfig for >>>>> backward compatibility with older kernels. >>>>> >>>>> $ cp defconfig .config >>>>> ‘defconfig’ -> ‘.config’ >>>>> $ make oldnoconfig >>>>> scripts/kconfig/conf --olddefconfig Kconfig >>>>> # >>>>> # configuration written to .config >>>>> # >>>>> $ grep USB_ETH .config >>>>> CONFIG_USB_ETH=y >>>>> CONFIG_USB_ETH_RNDIS=y >>>>> CONFIG_USB_ETH_EEM=y >>>>> >>>>> For more information, please refer to: >>>>> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=fbe98bb9ed3dae23e320c6b113e35f129538d14a >>>>> >>>> >>>> It was my understanding that this commit changed the Kconfig behaviour >>>> to set the selected options to =y and prevent the menu choice from >>>> "hiding" the options in a depedent choice menu. But maybe I'm remembering >>>> wrong. >>>> >>>> The point being, that with that commit in place. Doesn't the behaviour >>>> match what we want with yes and oldconfig ? >>>> >>> >>> Nope, that commit is fixing the issue when using make _defconfig >>> or make olddefconfig. Note that using make menuconfig already had the >>> correct behavior before that commit. >> >> right. I'm pretty familiar with that code, so I knew this worked. >> >>> >>> As shown in my commit log, using yes '' | make oldconfig is still >>> getting it wrong. >> >> But that was also my point. Since the target suggested in this >> patch hasn't always existed (and hence has a kernel version binding), >> why not use olddefconfig with this patch, and leave the functionality >> closer to its existing behaviour ? We'd still have a kernel capability >> binding, but we'd not have the =y converted to =m, and the default of >> 'y' for new functionality would be maintained. >> >>> >>>> .. I'll run some tests to confirm for myself, but I thought I'd throw >>>> the question out as well. I don't typically use defconfigs, so I need >>>> to do a bit of leg work. >>>> >>> >>> Yeah, using a full .config doesn't trigger that behavior. >> >> I don't use those either :) but the end result is the same. >> >> Cheers, >> >> Bruce >> >>> >>>> I don't have any big issues with the patch, but I just want to be sure, >>>> since changing this default could change the configs of many defconfig >>>> users, and they may have been unknowingly relying on the old behaviour. >>>> >>> >>> I can understand that. But I don't see any other way to make the really >>> expected behavior to work without risking breaking anything. >>> >> >