From: Saul Wold <sgw@linux.intel.com>
To: Zhu Yanjun <yanjun.zhu@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] pseudo-1.5.1: keep install command directory mode
Date: Tue, 18 Feb 2014 11:08:40 -0800 [thread overview]
Message-ID: <5303AFB8.2090605@linux.intel.com> (raw)
In-Reply-To: <1392632257-4669-1-git-send-email-yanjun.zhu@windriver.com>
On 02/17/2014 02:17 AM, Zhu Yanjun wrote:
> From: "yanjun.zhu" <yanjun.zhu@windriver.com>
>
> CQID:LIN5-17788
>
> when install command sets the created directory mode, pseudo will change
> the mode of the directory to 0700 incorrectly.
>
> Signed-off-by: yanjun.zhu <yanjun.zhu@windriver.com>
> ---
> .../pseudo-1.5.1-install-directory-mode.patch | 10 ++++++++++
> meta/recipes-devtools/pseudo/pseudo_1.5.1.bb | 3 ++-
> 2 files changed, 12 insertions(+), 1 deletion(-)
> create mode 100644 meta/recipes-devtools/pseudo/files/pseudo-1.5.1-install-directory-mode.patch
>
> diff --git a/meta/recipes-devtools/pseudo/files/pseudo-1.5.1-install-directory-mode.patch b/meta/recipes-devtools/pseudo/files/pseudo-1.5.1-install-directory-mode.patch
> new file mode 100644
> index 0000000..02e3da2
There is no patch header here, also have you checked with Peter S on
this change?
> --- /dev/null
> +++ b/meta/recipes-devtools/pseudo/files/pseudo-1.5.1-install-directory-mode.patch
> @@ -0,0 +1,10 @@
> +--- a/ports/unix/guts/mkdirat.c
> ++++ b/ports/unix/guts/mkdirat.c
> +@@ -25,6 +25,7 @@
> + stat_rc = base_fstatat(dirfd, path, &buf, AT_SYMLINK_NOFOLLOW);
> + #endif
> + if (stat_rc != -1) {
> ++ buf.st_mode = PSEUDO_DB_MODE(buf.st_mode, mode);
> + pseudo_client_op(OP_MKDIR, 0, -1, dirfd, path, &buf);
> + } else {
> + pseudo_debug(1, "mkdir of %s succeeded, but stat failed: %s\n",
> diff --git a/meta/recipes-devtools/pseudo/pseudo_1.5.1.bb b/meta/recipes-devtools/pseudo/pseudo_1.5.1.bb
> index bc92856..64115ca 100644
> --- a/meta/recipes-devtools/pseudo/pseudo_1.5.1.bb
> +++ b/meta/recipes-devtools/pseudo/pseudo_1.5.1.bb
> @@ -1,11 +1,12 @@
> require pseudo.inc
>
> -PR = "r4"
> +PR = "r5"
>
No PR Bumps needed any longer
Sau!
> SRC_URI = " \
> http://www.yoctoproject.org/downloads/${BPN}/${BPN}-${PV}.tar.bz2 \
> file://0001-pseudo_has_unload-add-function.patch \
> file://shutdownping.patch \
> + file://pseudo-1.5.1-install-directory-mode.patch \
> "
>
> SRC_URI[md5sum] = "5ec67c7bff5fe68c56de500859c19172"
>
next prev parent reply other threads:[~2014-02-18 19:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 10:17 [PATCH] pseudo-1.5.1: keep install command directory mode Zhu Yanjun
2014-02-18 19:08 ` Saul Wold [this message]
2014-02-18 21:31 ` Peter Seebach
2014-02-18 22:31 ` Saul Wold
-- strict thread matches above, loose matches on Subject: below --
2014-03-31 8:35 Kai Kang
2014-03-31 8:35 ` Kai Kang
2014-03-31 10:24 ` Martin Jansa
2014-03-31 14:37 ` Kang Kai
2014-03-31 15:11 ` Martin Jansa
2014-03-31 14:41 [PATCH] V2: " Kai Kang
2014-03-31 14:41 ` [PATCH] " Kai Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5303AFB8.2090605@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=yanjun.zhu@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox