From: Kang Kai <Kai.Kang@windriver.com>
To: Phil Blundell <pb@pbcl.net>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] update-rc.d.bbclass: fix inhibit check
Date: Thu, 20 Feb 2014 09:32:06 +0800 [thread overview]
Message-ID: <53055B16.7090004@windriver.com> (raw)
In-Reply-To: <1392810188.14769.356.camel@phil-desktop.brightsign>
On 2014年02月19日 19:43, Phil Blundell wrote:
> On Wed, 2014-02-19 at 18:59 +0800, Kai Kang wrote:
>> In update-rc.d.bbclass it checks variable INITSCRIPT_PACKAGES to avoid
>> inherit this class. But it is wrong logic to check INITSCRIPT_PACKAGES.
>> When 'sysvinit' is in 'DISTRO_FEATURES', INITSCRIPT_PACKAGES will not be
>> checked.
> Er, really? From the code you quoted...
>
>> # Check that this class isn't being inhibited (generally, by
>> # systemd.bbclass) before doing any work.
>> - if oe.utils.contains('DISTRO_FEATURES', 'sysvinit', True, False, d) or \
>> + if oe.utils.contains('DISTRO_FEATURES', 'sysvinit', True, False, d) and \
>> not d.getVar("INHIBIT_UPDATERCD_BBCLASS", True):
>> pkgs = d.getVar('INITSCRIPT_PACKAGES', True)
>> if pkgs == None:
> ... it seems that if sysvinit is in DISTRO_FEATURES then the outer "if"
> will evaluate to true and it will indeed proceed to check
> INITSCRIPT_PACKAGES in the last quoted line. Can you clarify what
> exactly is wrong here?
Sorry, as laurentiu comments, it is INHIBIT_UPDATERCD_BBCLASS which
variable will not be checked.
I'll update the comment with V2.
Regards,
Kai
>
> p.
>
>
>
>
--
Regards,
Neil | Kai Kang
next prev parent reply other threads:[~2014-02-20 1:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 10:59 [PATCH] update-rc.d.bbclass: fix inhibit check Kai Kang
2014-02-19 11:43 ` Phil Blundell
2014-02-20 1:32 ` Kang Kai [this message]
2014-02-19 12:19 ` Laurentiu Palcu
-- strict thread matches above, loose matches on Subject: below --
2014-02-20 2:11 [PATCH] V2: " Kai Kang
2014-02-20 2:11 ` [PATCH] " Kai Kang
2014-02-21 12:24 ` Burton, Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53055B16.7090004@windriver.com \
--to=kai.kang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=pb@pbcl.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox