From: "Kamble, Nitin A" <nitin.a.kamble@intel.com>
To: Phil Blundell <pb@pbcl.net>
Cc: Openembedded-core@lists.openembedded.org, saul.wold@intel.com
Subject: Re: [PATCH 1/1] QA_check: special case kernel modules for x32 targets
Date: Tue, 04 Mar 2014 14:26:33 -0800 [thread overview]
Message-ID: <53165319.7020506@intel.com> (raw)
In-Reply-To: <1393969091.4151.3.camel@e130.pbcl.net>
On 3/4/2014 1:38 PM, Phil Blundell wrote:
> On Tue, 2014-03-04 at 10:28 -0800, nitin.a.kamble@intel.com wrote:
>> - ("virtual/kernel" in provides) and (target_os == "linux-gnux32")):
>> + (("virtual/kernel" in provides) or (KERNEL_MODULE_RECIPE == "1")) and (target_os == "linux-gnux32")):
> Can you not use bb.data.inherits_class("module") rather than adding this
> extra variable?
This would simplify the code.
> Also, out of curiosity, I don't entirely understand how the code above
> can possibly work. KERNEL_MODULE_RECIPE is a bitbake variable that's
> either defined to 1 or not defined at all, right? Is there some special
> magic nowadays that allows you to refer to it transparently from python
> code without using d.getVar()?
There is no such special magic. This fix need to be fixed.
Thanks,
Nitin
> p.
>
>
prev parent reply other threads:[~2014-03-04 22:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 18:27 [PATCH 0/1] A QA_check fix for x32 kernel module packages nitin.a.kamble
2014-03-04 18:28 ` [PATCH 1/1] QA_check: special case kernel modules for x32 targets nitin.a.kamble
2014-03-04 21:38 ` Phil Blundell
2014-03-04 22:26 ` Kamble, Nitin A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53165319.7020506@intel.com \
--to=nitin.a.kamble@intel.com \
--cc=Openembedded-core@lists.openembedded.org \
--cc=pb@pbcl.net \
--cc=saul.wold@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox