From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 7FA1A6E7D7 for ; Thu, 13 Mar 2014 09:54:06 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.5/8.14.5) with ESMTP id s2D9s7RT000997 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 13 Mar 2014 02:54:07 -0700 (PDT) Received: from [128.224.162.204] (128.224.162.204) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.169.1; Thu, 13 Mar 2014 02:54:06 -0700 Message-ID: <5321803B.90400@windriver.com> Date: Thu, 13 Mar 2014 17:54:03 +0800 From: Chong Lu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: "Burton, Ross" References: <9477177f82743adfab34256b7bc002a37dd61787.1394093112.git.Chong.Lu@windriver.com> In-Reply-To: X-Originating-IP: [128.224.162.204] Cc: OE-core Subject: Re: [PATCH 1/1] dbus: fix a hard dependency about dbus-ptest X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Mar 2014 09:54:09 -0000 Content-Type: multipart/alternative; boundary="------------030109020109070200010702" --------------030109020109070200010702 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 03/06/2014 06:04 PM, Burton, Ross wrote: > On 6 March 2014 08:06, Chong Lu wrote: >> +PACKAGES += "dbus-ptest" >> +ALLOW_EMPTY_${PN}-ptest = "1" >> +RDEPENDS_${PN}-ptest = "${@base_contains('IMAGE_FEATURES', 'ptest-pkgs', 'dbus-test-ptest', 'dbus-test', d)}" Hi Ross, Do you have any suggestion about this issue? If we don't check IMAGE_FEATURES, I have no way to resolve this problem that only build but not install ptest. I'm very confused. Best Regards Chong > Nice idea, but wouldn't a more correct solution be to have dbus-ptest > added to PACKAGES conditionally (instead of always generating > dbus-ptest and conditionally adding the dependency)? > > Ross > Clearly I wasn't thinking clearly last week. You can't check > IMAGE_FEATURES in a non-image recipe so this isn't a good solution. > > Ross > > --------------030109020109070200010702 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit
On 03/06/2014 06:04 PM, Burton, Ross wrote:
On 6 March 2014 08:06, Chong Lu <Chong.Lu@windriver.com> wrote:

+PACKAGES += "dbus-ptest"
+ALLOW_EMPTY_${PN}-ptest = "1"
+RDEPENDS_${PN}-ptest = "${@base_contains('IMAGE_FEATURES', 'ptest-pkgs', 'dbus-test-ptest', 'dbus-test', d)}"
Hi Ross,

Do you have any suggestion about this issue?
If we don't check IMAGE_FEATURES, I have no way to resolve this problem that only build but not install ptest. I'm very confused.

Best Regards
Chong

Nice idea, but wouldn't a more correct solution be to have dbus-ptest
added to PACKAGES conditionally (instead of always generating
dbus-ptest and conditionally adding the dependency)?

Ross
Clearly I wasn't thinking clearly last week.  You can't check
IMAGE_FEATURES in a non-image recipe so this isn't a good solution.

Ross

--------------030109020109070200010702--