From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 4D55D6F466 for ; Mon, 17 Mar 2014 02:09:32 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.5/8.14.5) with ESMTP id s2H29WVJ018331 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Sun, 16 Mar 2014 19:09:32 -0700 (PDT) Received: from [128.224.162.204] (128.224.162.204) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.169.1; Sun, 16 Mar 2014 19:09:32 -0700 Message-ID: <53265958.6050806@windriver.com> Date: Mon, 17 Mar 2014 10:09:28 +0800 From: Chong Lu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Paul Eggleton References: <3035449.StOc9XfpzV@peggleto-mobl5.ger.corp.intel.com> <5322C873.6020709@windriver.com> <232470057.ZuPMps2Ccl@peggleto-mobl5.ger.corp.intel.com> In-Reply-To: <232470057.ZuPMps2Ccl@peggleto-mobl5.ger.corp.intel.com> X-Originating-IP: [128.224.162.204] Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 1/1] dbus: fix a hard dependency about dbus-ptest X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Mar 2014 02:09:36 -0000 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 03/14/2014 06:12 PM, Paul Eggleton wrote: > On Friday 14 March 2014 17:14:27 Chong Lu wrote: >> On 03/13/2014 06:01 PM, Paul Eggleton wrote: >>> On Thursday 13 March 2014 17:54:03 Chong Lu wrote: >>>> On 03/06/2014 06:04 PM, Burton, Ross wrote: >>>>> On 6 March 2014 08:06, Chong Lu wrote: >>>>>> +PACKAGES += "dbus-ptest" >>>>>> +ALLOW_EMPTY_${PN}-ptest = "1" >>>>>> +RDEPENDS_${PN}-ptest = "${@base_contains('IMAGE_FEATURES', >>>>>> 'ptest-pkgs', >>>>>> 'dbus-test-ptest', 'dbus-test', d)}" >>>>> Clearly I wasn't thinking clearly last week. You can't check >>>>> IMAGE_FEATURES in a non-image recipe so this isn't a good solution. >>>> Do you have any suggestion about this issue? >>>> If we don't check IMAGE_FEATURES, I have no way to resolve this problem >>>> that only build but not install ptest. I'm very confused. >>> This should check DISTRO_FEATURES, not IMAGE_FEATURES. Assuming ptest is >>> in >>> DISTRO_FEATURES, even if ptest is not in IMAGE_FEATURES it doesn't matter >>> if the dependency between dbus-ptest and dbus-ptest-ptest exists because >>> dbus- ptest itself shouldn't be in the image, so dbus-ptest-ptest >>> shouldn't be pulled in either. Does that make sense? >>> >>> Cheers, >>> Paul >> Hi Paul, >> >> Thanks for your reply! >> But I still have a question. >> >> I try to following way: >> >> # git diff >> diff --git a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb >> b/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb >> index bc260de..50dfe54 100644 >> --- a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb >> +++ b/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb >> @@ -9,6 +9,7 @@ DEPENDS = "python-pygobject dbus dbus-glib" >> >> RDEPENDS_${PN} += "make" >> RDEPENDS_${PN}-dev = "" >> +ALLOW_EMPTY_${PN} = "1" >> >> SRC_URI = "http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \ >> file://tmpdir.patch \ >> diff --git a/meta/recipes-core/dbus/dbus.inc >> b/meta/recipes-core/dbus/dbus.inc >> index 677ff78..ba7f3cb 100644 >> --- a/meta/recipes-core/dbus/dbus.inc >> +++ b/meta/recipes-core/dbus/dbus.inc >> @@ -6,7 +6,7 @@ LICENSE = "AFL-2 | GPLv2+" >> LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \ >> file://dbus/dbus.h;beginline=6;endline=20;md5=7755c9d7abccd5dbd25a6a974538bb >> 3c" DEPENDS = "expat virtual/libintl" >> -RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', >> 'dbus-ptest-ptest', '', d)}" >> +RDEPENDS_dbus = "dbus-ptest" > The line above is the problem. You *cannot* do this or dbus-ptest (and > therefore dbus-ptest-ptest) will always be installed whether you want it or > not. You need to remove this line. > > Cheers, > Paul > Hi Paul, Do you mean the patch we only need to remove RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest-ptest', '', d)}" in dbus.inc ? If do this, we can't build and install dbus-ptest through `bitbake dbus' command. How to relate between dbus and dbus-ptest? Best Regards Chong