Re: [PATCH v3 0/7] wic: Add --rootfs option to --source param

["João Henrique Ferreira de Freitas" <joaohf@gmail.com>]

Hi Tom,

Em 28-03-2014 18:38, Tom Zanussi escreveu:
> On Thu, 2014-03-27 at 19:07 -0300, João Henrique Ferreira de Freitas
> wrote:
>
>
> When testing, I noticed a problem I introduced when adding the plugin
> support - I'll submit a patch for it, but the fix is here:
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=tzanussi/wic-bitbake-env-fix&id=222d52976466464a3ff184e07c0c884c8f821dbc

Do you have any automatic way to test wic? Like a tool to create 
valid/invalid command line combinations ?

>
> Moving on to the generic connection versions, however, I still ran into
> problems.  Here's the 'directdisk-multi-indirect-both.wks' file I used
> for that test:
>
> part /boot --source bootimg-pcbios --ondisk sda --fstype=msdos --label boot --active --align 1024
> part / --source rootfs --rootfs-dir="rootfs1" --ondisk sda --fstype=ext3 --label platform --align 1024
>
> part /standby --source rootfs --rootfs-dir="rootfs2" --ondisk sda --fstype=ext3 --label secondary --align 1024
>
> bootloader  --timeout=0  --append="rootwait rootfstype=ext3 video=vesafb vga=0x318 console=tty0"
>
>
> Both the -e and manual failed in the same way:
>
> [trz@empanada build]$ wic create directdisk-multi-indirect-both --rootfs-dir rootfs1=/home/trz/yocto/master-cur/build/tmp/work/crownbay-poky-linux/core-image-minimal/1.0-r0/rootfs/ --rootfs-dir rootfs2=/home/trz/yocto/master-cur/build/tmp/work/crownbay-poky-linux/core-image-minimal/1.0-r0/rootfs/ -e core-image-minimal
> Checking basic build environment...
> Done.
>
> Creating image(s)...
>
> Traceback (most recent call last):
>    File "/home/trz/yocto/master-cur/scripts/wic", line 254, in <module>
>      ret = main()
>    File "/home/trz/yocto/master-cur/scripts/wic", line 249, in main
>      invoke_subcommand(args, parser, wic_help_usage, subcommands)
>    File "/home/trz/yocto/master-cur/scripts/lib/image/help.py", line 73, in invoke_subcommand
>      subcommands.get(args[0], subcommand_error)[0](args[1:], usage)
>    File "/home/trz/yocto/master-cur/scripts/wic", line 199, in wic_create_subcommand
>      image_output_dir, options.debug, options.properties_file)
>    File "/home/trz/yocto/master-cur/scripts/lib/image/engine.py", line 246, in wic_create
>      cr.main(direct_args)
> KeyError: 'ROOTFS_DIR'
>
>
> [trz@empanada build]$ wic create directdisk-multi-indirect-both -b /home/trz/yocto/master-cur/build/tmp/sysroots/crownbay/usr/share -k /home/trz/yocto/master-cur/build/tmp/sysroots/crownbay/usr/src/kernel -n /home/trz/yocto/master-cur/build/tmp/sysroots/x86_64-linux --rootfs-dir rootfs1=/home/trz/yocto/master-cur/build/tmp/work/crownbay-poky-linux/core-image-minimal/1.0-r0/rootfs/ --rootfs-dir rootfs2=/home/trz/yocto/master-cur/build/tmp/work/crownbay-poky-linux/core-image-minimal/1.0-r0/rootfs/
> Creating image(s)...
>
> Traceback (most recent call last):
>    File "/home/trz/yocto/master-cur/scripts/wic", line 254, in <module>
>      ret = main()
>    File "/home/trz/yocto/master-cur/scripts/wic", line 249, in main
>      invoke_subcommand(args, parser, wic_help_usage, subcommands)
>    File "/home/trz/yocto/master-cur/scripts/lib/image/help.py", line 73, in invoke_subcommand
>      subcommands.get(args[0], subcommand_error)[0](args[1:], usage)
>    File "/home/trz/yocto/master-cur/scripts/wic", line 153, in wic_create_subcommand
>      rootfs_dir = options.rootfs_dir['ROOTFS_DIR']
> KeyError: 'ROOTFS_DIR'

Ok, the problem was that no --rootfs-dir (without a connect) was passed. 
Like this:

... --rootfs-dir /home/trz/yocto/master-cur/build/tmp/work/crownbay-poky-linux/core-image-minimal/1.0-r0/rootfs/ --rootfs-dir rootfs2=/home/trz/yocto/master-cur/build/tmp/work/crownbay-poky-linux/core-image-minimal/1.0-r0/rootfs/


I've fixed the code to get this situation.

Thanks.

-- 
João Henrique Ferreira de Freitas - joaohf_at_gmail.com
Campinas-SP-Brasil