On 2014?04?02? 06:33, Otavio Salvador wrote: > Hello, > > On Tue, Apr 1, 2014 at 7:49 AM, Richard Purdie > wrote: >> On Tue, 2014-04-01 at 17:09 +0800, Kai Kang wrote: >>> From: Li Wang >>> >>> ptest output format is incorrect, according to yocto Development Manual >>> (http://www.yoctoproject.org/docs/latest/dev-manual/dev-manual.html#testing-packages-with-ptest) >>> >>> The test generates output in the format used by Automake: >>> : >>> where the result can be PASS, FAIL, or SKIP, and the testname can be any identifying string. >>> >>> So we should change the test result format to match yocto ptest rules. >>> >>> Signed-off-by: Li Wang >>> Signed-off-by: Robert Yang >>> Signed-off-by: Kai Kang >>> --- >>> meta/recipes-devtools/cmake/cmake.inc | 1 + >>> .../cmake/cmake/follow_ptest_output_format.patch | 118 +++++++++++++++++++++ >>> 2 files changed, 119 insertions(+) >>> create mode 100644 meta/recipes-devtools/cmake/cmake/follow_ptest_output_format.patch >>> >>> diff --git a/meta/recipes-devtools/cmake/cmake.inc b/meta/recipes-devtools/cmake/cmake.inc >>> index 1d5303f..254af45 100644 >>> --- a/meta/recipes-devtools/cmake/cmake.inc >>> +++ b/meta/recipes-devtools/cmake/cmake.inc >>> @@ -17,6 +17,7 @@ SRC_URI = "http://www.cmake.org/files/v${CMAKE_MAJOR_VERSION}/cmake-${PV}.tar.gz >>> file://aarch64-kwsys.patch \ >>> file://qt4-fail-silent.patch \ >>> file://cmake-2.8.11.2-FindFreetype.patch \ >>> + file://follow_ptest_output_format.patch \ >>> " >>> >>> inherit autotools-brokensep >>> diff --git a/meta/recipes-devtools/cmake/cmake/follow_ptest_output_format.patch b/meta/recipes-devtools/cmake/cmake/follow_ptest_output_format.patch >>> new file mode 100644 >>> index 0000000..5428df2 >>> --- /dev/null >>> +++ b/meta/recipes-devtools/cmake/cmake/follow_ptest_output_format.patch >>> @@ -0,0 +1,118 @@ >>> +cmake: follow ptest output format >>> + >>> +ptest output format is incorrect, according to yocto Development Manual >>> +(http://www.yoctoproject.org/docs/latest/dev-manual/dev-manual.html#testing-packages-with-ptest) >>> +5.10.6. Testing Packages With ptest >>> +The test generates output in the format used by Automake: >>> +: >>> +where the result can be PASS, FAIL, or SKIP, and the testname can be any identifying string. >>> +So we should change the test result format to match yocto ptest rules. >>> + >>> +Signed-off-by: Li Wang >> No upstream status. Is there any chance of this going upstream? Might we >> be better off postprocessing the output with a script to put it into the >> right format? > I agree with both remarks. It'd be good to try to get it somehow > integrated upstream and for OE-Core interim solution would be better > to 'convert' using an external script. This may break external tests > tools people may be using as it changes the format without allowing to > 'revert' for normal format. > OK. I'll send it upstream and see what's going on. -- Regards, Neil | Kai Kang