From: Valentin Popa <valentin.popa@intel.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] mesa: double check for eglplatform.h
Date: Mon, 14 Apr 2014 16:57:37 +0300 [thread overview]
Message-ID: <534BE951.8030701@intel.com> (raw)
In-Reply-To: <1397483657-8081-1-git-send-email-valentin.popa@intel.com>
On 04/14/2014 04:54 PM, Valentin Popa wrote:
> Even if 'egl' is in PACKAGECONFIG, mesa egl support
> can be disabled explicitly (using a .bbappend, for example).
> This patch adds another check for the existence
> of eglplatform.h before 'sed' can alter it.
>
> Signed-off-by: Valentin Popa <valentin.popa@intel.com>
> ---
> meta/recipes-graphics/mesa/mesa_9.1.6.bb | 4 +++-
> meta/recipes-graphics/mesa/mesa_git.bb | 4 +++-
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-graphics/mesa/mesa_9.1.6.bb b/meta/recipes-graphics/mesa/mesa_9.1.6.bb
> index 6e9cd82..388cfd7 100644
> --- a/meta/recipes-graphics/mesa/mesa_9.1.6.bb
> +++ b/meta/recipes-graphics/mesa/mesa_9.1.6.bb
> @@ -19,6 +19,8 @@ S = "${WORKDIR}/Mesa-${PV}"
> #make eglplatform.h independent of MESA_EGL_NO_X11_HEADER
> do_install_append() {
> if ${@base_contains('PACKAGECONFIG', 'egl', 'true', 'false', d)}; then
> - sed -i -e 's/^#ifdef MESA_EGL_NO_X11_HEADERS/#if ${@base_contains('DISTRO_FEATURES', 'x11', '0', '1', d)}/' ${D}${includedir}/EGL/eglplatform.h
> + if [ -e "${D}${includedir}/EGL/eglplatform.h" ]; then
> + sed -i -e 's/^#ifdef MESA_EGL_NO_X11_HEADERS/#if ${@base_contains('DISTRO_FEATURES', 'x11', '0', '1', d)}/' ${D}${includedir}/EGL/eglplatform.h
> + fi
> fi
> }
> \ No newline at end of file
> diff --git a/meta/recipes-graphics/mesa/mesa_git.bb b/meta/recipes-graphics/mesa/mesa_git.bb
> index 1babcc0..714911f 100644
> --- a/meta/recipes-graphics/mesa/mesa_git.bb
> +++ b/meta/recipes-graphics/mesa/mesa_git.bb
> @@ -23,6 +23,8 @@ S = "${WORKDIR}/git"
> #make eglplatform.h independent of MESA_EGL_NO_X11_HEADER
> do_install_append() {
> if ${@base_contains('PACKAGECONFIG', 'egl', 'true', 'false', d)}; then
> - sed -i -e 's/^#ifdef MESA_EGL_NO_X11_HEADERS/#if ${@base_contains('DISTRO_FEATURES', 'x11', '0', '1', d)}/' ${D}${includedir}/EGL/eglplatform.h
> + if [ -e "${D}${includedir}/EGL/eglplatform.h" ]; then
> + sed -i -e 's/^#ifdef MESA_EGL_NO_X11_HEADERS/#if ${@base_contains('DISTRO_FEATURES', 'x11', '0', '1', d)}/' ${D}${includedir}/EGL/eglplatform.h
> + fi
> fi
> }
Not sure why subject-prefix didn't work. I'll resend this. Please ignore!
prev parent reply other threads:[~2014-04-14 13:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 13:54 [PATCH] mesa: double check for eglplatform.h Valentin Popa
2014-04-14 13:57 ` Valentin Popa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534BE951.8030701@intel.com \
--to=valentin.popa@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox