Re: [PATCH v2] serial-getty service: Add linux as default TERM

Jonathan Liu
2014-05-04T10:17:42Z

On 4/05/2014 9:36 AM, Joel Fernandes wrote:
> In poky with systemd enabled, vt102 is selected for getty
> causing user to experience a very crappy terminal. Default
> TERM to linux.
>
> Signed-off-by: Joel Fernandes <joelf@ti.com>
> ---
> v2: Dropped PR bump
>
> .../systemd-serialgetty/serial-getty@.service | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-core/systemd/systemd-serialgetty/serial-getty@.service b/meta/recipes-core/systemd/systemd-serialgetty/serial-getty@.service
> index 865de34..eb2280b 100644
> --- a/meta/recipes-core/systemd/systemd-serialgetty/serial-getty@.service
> +++ b/meta/recipes-core/systemd/systemd-serialgetty/serial-getty@.service
> @@ -20,6 +20,7 @@ Before=getty.target
> IgnoreOnIsolate=yes
>
> [Service]
> +Environment="TERM=linux"
> ExecStart=-/sbin/agetty --keep-baud %I @BAUDRATE@ $TERM
> Type=idle
> Restart=always
I would prefer:
Environment="TERM=xterm"
ExecStart=-/sbin/agetty -8 --keep-baud %I @BAUDRATE@ $TERM

"xterm" as it is much more widely supported than "linux". Also, PuTTY
uses "xterm" by default.
-8 to assume the tty is 8-bit clean and disable parity detection. I have
had some issues where parity sometimes gets enabled even though the
serial line is 8-bit clean and I end up with garbage on the serial terminal.

Regards,
Jonathan