From: Philip Tricca <flihp@twobit.us>
To: Saul Wold <sgw@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] grub-efi: Use a variable to specify built-in grub modules.
Date: Mon, 05 May 2014 12:49:00 -0400 [thread overview]
Message-ID: <5367C0FC.40400@twobit.us> (raw)
In-Reply-To: <5367B323.30901@linux.intel.com>
On 05/05/2014 11:49 AM, Saul Wold wrote:
> On 05/04/2014 03:34 PM, Philip Tricca wrote:
>> ping ...
>>
>
> It was merged on 4/16!
Whoops. Was watching the mailing list, not git. My bad.
Thanks!
Philip
> Sau!
>
>> On 04/15/2014 09:16 PM, Philip Tricca wrote:
>>> The previous behavior defines a static set of modules that are built
>>> into the grub efi executable. This works fine for a limited set of boot
>>> environments namely the standard linux/initrd. This patch conditionally
>>> assigns the same modules to a variable. This allows other meta layers
>>> to add additional modules or completely override the defaults. The use
>>> case driving this patch is the use of multiboot2 and related modules.
>>>
>>> Signed-off-by: Philip Tricca <flihp@twobit.us>
>>> ---
>>> meta/recipes-bsp/grub/grub-efi_2.00.bb | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-bsp/grub/grub-efi_2.00.bb
>>> b/meta/recipes-bsp/grub/grub-efi_2.00.bb
>>> index 6944cb2..4b43749 100644
>>> --- a/meta/recipes-bsp/grub/grub-efi_2.00.bb
>>> +++ b/meta/recipes-bsp/grub/grub-efi_2.00.bb
>>> @@ -70,12 +70,14 @@ do_install_class-native() {
>>> install -m 755 grub-mkimage ${D}${bindir}
>>> }
>>>
>>> +GRUB_BUILDIN ?= "boot linux ext2 fat serial part_msdos part_gpt
>>> normal efi_gop iso9660 search"
>>> +
>>> do_deploy() {
>>> # Search for the grub.cfg on the local boot media by using the
>>> # built in cfg file provided via this recipe
>>> grub-mkimage -c ../cfg -p /EFI/BOOT -d ./grub-core/ \
>>> -O ${GRUB_TARGET}-efi -o ./${GRUB_IMAGE} \
>>> - boot linux ext2 fat serial part_msdos part_gpt
>>> normal efi_gop iso9660 search
>>> + ${GRUB_BUILDIN}
>>> install -m 644 ${B}/${GRUB_IMAGE} ${DEPLOYDIR}
>>> }
>>>
>>>
>>
prev parent reply other threads:[~2014-05-05 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 1:16 [PATCH] grub-efi: Use a variable to specify built-in grub modules Philip Tricca
2014-05-04 22:34 ` Philip Tricca
2014-05-05 15:49 ` Saul Wold
2014-05-05 16:49 ` Philip Tricca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5367C0FC.40400@twobit.us \
--to=flihp@twobit.us \
--cc=openembedded-core@lists.openembedded.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox