Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Paul Eggleton" <bluelightning@bluelightning.org>
To: Bjarne Michelsen <bjarne_michelsen@hotmail.com>,
	openembedded-core@lists.openembedded.org
Cc: Khem Raj <raj.khem@gmail.com>
Subject: Re: [OE-core] [PATCH] devtool: default to empty string, if LIC_FILES_CHKSUM is not available
Date: Tue, 07 Jul 2020 09:47:45 +1200	[thread overview]
Message-ID: <5369173.DvuYhMxLoT@linc> (raw)
In-Reply-To: <0f90bcd9-199e-df33-00d2-11009898430a@gmail.com>

Hi Khem / Bjarne

On Tuesday, 7 July 2020 07:50:47 NZST Khem Raj wrote:
> On 7/6/20 12:42 PM, Bjarne Michelsen wrote:
> > [Bug 13971] https://bugzilla.yoctoproject.org/show_bug.cgi?id=13971
> > 
> > A recipe using LICENSE=CLOSED would normally not have LIC_FILES_CHKSUM
> > set.
> > If LIC_FILES_CHKSUM was not set, it would cause `devtool upgrade` to fail.
> > 
> > This fixes the issue by defaulting to an empty string if
> > LIC_FILES_CHKSUM is not found.
> 
> would it do just for recipes which use CLOSED for license ?
> since we are synthesizing the checksum, It would be good to remain
> prudent and not empty it out in general when non existent, perhaps
> a warning for user to fix it in such cases would be appropriate

It would be nice to show an error if LIC_FILES_CHKSUM is empty and LICENSE != 
"CLOSED", although one would imagine this would be a fairly rare situation 
given that LIC_FILES_CHKSUM is mandated by the build system in that case and 
devtool upgrade requires a recipe to already exist (presumably one that has 
been built before). 

The fix itself is reasonable but the bug reference should be in the following 
form:

Fixes: [YOCTO #13971].

Thanks
Paul




      reply	other threads:[~2020-07-06 21:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-06 19:42 [PATCH] devtool: default to empty string, if LIC_FILES_CHKSUM is not available Bjarne Michelsen
2020-07-06 19:50 ` [OE-core] " Khem Raj
2020-07-06 21:47   ` Paul Eggleton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5369173.DvuYhMxLoT@linc \
    --to=bluelightning@bluelightning.org \
    --cc=bjarne_michelsen@hotmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox