From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (unknown [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 88D9A660E1 for ; Thu, 15 May 2014 02:32:53 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.5/8.14.5) with ESMTP id s4F2Wn46018495 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 14 May 2014 19:32:49 -0700 (PDT) Received: from [128.224.162.182] (128.224.162.182) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.169.1; Wed, 14 May 2014 19:32:49 -0700 Message-ID: <5374273C.1040603@windriver.com> Date: Thu, 15 May 2014 10:32:28 +0800 From: Wenlin Kang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Christopher Larson References: <1400059849-7711-1-git-send-email-wenlin.kang@windriver.com> In-Reply-To: X-Originating-IP: [128.224.162.182] Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH] autotools.bbclass: fixed bash build error X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 May 2014 02:32:56 -0000 Content-Type: multipart/alternative; boundary="------------050509080309010700020400" --------------050509080309010700020400 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit On 2014年05月15日 01:45, Christopher Larson wrote: > > On Wed, May 14, 2014 at 2:30 AM, Wenlin Kang > > wrote: > > When build bash, a error occurs, the cause is that autotools uses > improper Makefile.in.in which is from > path/gettext/po/ but not bash > itself in bash/po/,so to avoid some error to occur, we should use > package itself Makefile.in.in file if it has. > > Signed-off-by: Wenlin Kang > > > > This will cause breakage when the shipped Makefile.in.in > gettext version mismatches with the > gettext-native/gettext we built. but if we directly use gettext-native/gettext/Makefile.in.in just as now, for bash, it do occur some problem, can't get correct value of PACKAGE, VERSION due to use incorrect variable name(the right should is PACKAGE_NAME, PACKAGE_VERSION) , can't get BUILD_DIR, and can't get po-directories(it indeed isn't exist) in bash/po/Makefile. these all can trigger a build error in bash/po , so, whether we can have a much well solution for it, can you have some good advices, thanks? > -- > Christopher Larson > clarson at kergoth dot com > Founder - BitBake, OpenEmbedded, OpenZaurus > Maintainer - Tslib > Senior Software Engineer, Mentor Graphics -- Thanks, Wenlin Kang --------------050509080309010700020400 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit
On 2014年05月15日 01:45, Christopher Larson wrote:

On Wed, May 14, 2014 at 2:30 AM, Wenlin Kang <wenlin.kang@windriver.com> wrote:
When build bash, a error occurs, the cause is that autotools uses
improper Makefile.in.in which is from path/gettext/po/ but not bash
itself in bash/po/,so to avoid some error to occur, we should use
package itself Makefile.in.in file if it has.

Signed-off-by: Wenlin Kang <wenlin.kang@windriver.com>

This will cause breakage when the shipped Makefile.in.in gettext version mismatches with the gettext-native/gettext we built.

    but if we directly use gettext-native/gettext/Makefile.in.in just as now,  for bash, it do occur some problem,  can't  get  correct value of PACKAGE, VERSION due to use incorrect  variable name(the right should is PACKAGE_NAME, PACKAGE_VERSION) , can't  get BUILD_DIR, and  can't get po-directories(it indeed isn't exist) in bash/po/Makefile.
these all can trigger a build error in bash/po ,  so, whether we can have a much well solution for it, can you have some good advices, thanks?
--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics 


-- 
Thanks,
Wenlin Kang
--------------050509080309010700020400--