From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (unknown [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 4F4C266078 for ; Fri, 23 May 2014 09:45:49 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.5/8.14.5) with ESMTP id s4N9jo39019710 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 23 May 2014 02:45:50 -0700 (PDT) Received: from [128.224.162.182] (128.224.162.182) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.169.1; Fri, 23 May 2014 02:45:49 -0700 Message-ID: <537F18B0.6060009@windriver.com> Date: Fri, 23 May 2014 17:45:20 +0800 From: Wenlin Kang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: "Burton, Ross" References: <1400833868-27473-1-git-send-email-wenlin.kang@windriver.com> In-Reply-To: X-Originating-IP: [128.224.162.182] Cc: OE-core Subject: Re: [PATCH] bash: fixed bash build error X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 May 2014 09:45:51 -0000 Content-Type: multipart/alternative; boundary="------------020000060103000601040303" --------------020000060103000601040303 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit On 2014年05月23日 17:29, Burton, Ross wrote: > First, bash builds fine for me, so can you elaborate on what the > situation that causes the failure is. build bash, then check temp/log.do_install, we can see error , this trigger when builds in bash/po/ > The patch is missing upstream-status and signed-off-by. For build > fixes I'd hope that there would be communication with upstream. > > On 23 May 2014 09:31, Wenlin Kang wrote: >> +--- bash-4.3-org/aclocal.m4 2014-05-23 15:28:54.252565146 +0800 >> ++++ bash-4.3/aclocal.m4 2014-05-23 15:33:19.924570133 +0800 > aclocal.m4 is overwritten in do_configure when we run autoreconf so > anything changed in that file will be lost. in bash, I have double checking, original a clocal.m4 will be "cat" to acinclude.m4 at begin of do_configure not changed, and after regenerated acloacl.m4 will include acinclude.m4, so the changing in original aclocal.m4 will be not lost. > > Ross > > -- Thanks, Wenlin Kang --------------020000060103000601040303 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit
On 2014年05月23日 17:29, Burton, Ross wrote:
First, bash builds fine for me, so can you elaborate on what the
situation that causes the failure is.
 build bash, then check temp/log.do_install, we can see error , this trigger when builds in bash/po/
The patch is missing upstream-status and signed-off-by.  For build
fixes I'd hope that there would be communication with upstream.

On 23 May 2014 09:31, Wenlin Kang <wenlin.kang@windriver.com> wrote:

+--- bash-4.3-org/aclocal.m4    2014-05-23 15:28:54.252565146 +0800
++++ bash-4.3/aclocal.m4        2014-05-23 15:33:19.924570133 +0800

aclocal.m4 is overwritten in do_configure when we run autoreconf so
anything changed in that file will be lost.
   in bash, I have  double checking,  original a clocal.m4 will be "cat" to acinclude.m4 at begin of do_configure not changed,
   and  after regenerated acloacl.m4 will include acinclude.m4, so the changing in  original aclocal.m4 will be not lost.

Ross





-- 
Thanks,
Wenlin Kang
--------------020000060103000601040303--