Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Chong Lu <Chong.Lu@windriver.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] oprofile: Add PTEST regression testing to oprofile
Date: Fri, 6 Jun 2014 09:22:01 +0800	[thread overview]
Message-ID: <539117B9.1050504@windriver.com> (raw)
In-Reply-To: <CAP9ODKqwiQyGbBB0J2x=WzgDbXwDsnhi1OKR8nwSgNRUHk3_gg@mail.gmail.com>


On 06/05/2014 11:21 PM, Otavio Salvador wrote:
> On Thu, Jun 5, 2014 at 5:44 AM, Chong Lu <Chong.Lu@windriver.com> wrote:
>> The commit changes the oe-core oprofile recipe by adding the PTEST
>> interface, implementing do_compile_ptest() and do_install_ptest().
>>
>> The install routine adds several files that only the regression tests
>> require. Also, a patch is necessary to inhibit executing the tests on
>> the build host and to point to the correct target directory for the
>> libutil++ test 'file-manip-tests'.
>>
>> That test requires the recipe to set SRCDIR in the build environment
>> instead of determining the value from build-time host paths as for a
>> self-hosted build.
>>
>> Signed-off-by: Dave Lerner <dave.lerner@windriver.com>
>> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
>> ---
>>   meta/recipes-kernel/oprofile/oprofile.inc          | 31 ++++++-
>>   .../oprofile/oprofile-cross-compile-tests.patch    | 98 ++++++++++++++++++++++
>>   meta/recipes-kernel/oprofile/oprofile/run-ptest    | 18 ++++
>>   3 files changed, 145 insertions(+), 2 deletions(-)
>>   create mode 100644 meta/recipes-kernel/oprofile/oprofile/oprofile-cross-compile-tests.patch
>>   create mode 100644 meta/recipes-kernel/oprofile/oprofile/run-ptest
>>
>> diff --git a/meta/recipes-kernel/oprofile/oprofile.inc b/meta/recipes-kernel/oprofile/oprofile.inc
>> index ccf9f9f..0a7f7fd 100644
>> --- a/meta/recipes-kernel/oprofile/oprofile.inc
>> +++ b/meta/recipes-kernel/oprofile/oprofile.inc
>> @@ -20,9 +20,11 @@ FILES_${PN}-staticdev += "${libdir}/${BPN}/lib*.a"
>>
>>   SRC_URI = "file://opstart.patch \
>>              file://oprofile-root.patch \
>> -           file://acinclude.m4"
>> +           file://acinclude.m4 \
>> +           file://oprofile-cross-compile-tests.patch \
>> +           file://run-ptest"
>>
>> -inherit autotools-brokensep pkgconfig
>> +inherit autotools-brokensep ptest
> You removed pkgconfig, why?
>
It's my mistake. pkgconfig should not be removed. I will resend V2.

Best Regards
Chong


  reply	other threads:[~2014-06-06  1:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05  8:44 [PATCH 0/2] oprofile: Add PTEST and Determine the root home directory dynamically Chong Lu
2014-06-05  8:44 ` [PATCH 1/2] oprofile: Add PTEST regression testing to oprofile Chong Lu
2014-06-05 15:21   ` Otavio Salvador
2014-06-06  1:22     ` Chong Lu [this message]
2014-06-05  8:44 ` [PATCH 2/2] oprofile: Determine the root home directory dynamically Chong Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539117B9.1050504@windriver.com \
    --to=chong.lu@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox