From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: grygorii tertychnyi <gtertych@cisco.com>,
openembedded-core@lists.openembedded.org
Cc: xe-linux-external@cisco.com
Subject: Re: [PATCH v2] lib/oe/utils: add eol to format_pkg_list()
Date: Thu, 04 Oct 2018 18:03:56 +0100 [thread overview]
Message-ID: <53961341e042e2493580d379271b9af43c2b0620.camel@linuxfoundation.org> (raw)
In-Reply-To: <20181004052931.21389-1-gtertych@cisco.com>
On Thu, 2018-10-04 at 08:29 +0300, grygorii tertychnyi via
Openembedded-core wrote:
> Append '\n' to the non-empty formatted string before return. If you
> write it to the (manifest) file, it will ensure file ends with a
> newline.
>
> Many GNU utilities have problems processing the last line of a file
> if it is not '\n' terminated. E.g. if the last line is not terminated
> by a newline character, then "read" will read it but return false,
> leaving the broken partial line in the read variable(s).
> It can also break or adversely affect some text processing tools,
> that operate on the file.
>
> Signed-off-by: grygorii tertychnyi <gtertych@cisco.com>
> ---
>
> Changes in v2:
> o make sure we don't append '\n' to the empty string
This still breaks things which doesn't give me much confidence in this
change for 2.6 :(.
https://autobuilder.yoctoproject.org/typhoon/#/builders/28/builds/90/st
eps/7/logs/step2d
https://autobuilder.yoctoproject.org/typhoon/#/builders/24/builds/87/st
eps/7/logs/step4b
and more...
Cheers,
Richard
prev parent reply other threads:[~2018-10-04 17:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 5:29 [PATCH v2] lib/oe/utils: add eol to format_pkg_list() grygorii tertychnyi
2018-10-04 17:03 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53961341e042e2493580d379271b9af43c2b0620.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=gtertych@cisco.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox