From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id D6AF76B232 for ; Wed, 11 Jun 2014 08:20:17 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.5/8.14.5) with ESMTP id s5B8JjuA021994 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 11 Jun 2014 01:19:45 -0700 (PDT) Received: from [128.224.162.182] (128.224.162.182) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.169.1; Wed, 11 Jun 2014 01:19:44 -0700 Message-ID: <539810F0.3090001@windriver.com> Date: Wed, 11 Jun 2014 16:18:56 +0800 From: Wenlin Kang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Saul Wold , References: <1401760525-17167-1-git-send-email-wenlin.kang@windriver.com> <538D4152.5030308@linux.intel.com> <538D75AD.8030103@windriver.com> In-Reply-To: <538D75AD.8030103@windriver.com> X-Originating-IP: [128.224.162.182] Subject: Re: [PATCH] fetch2/svn.py: fix Unable to fetch URL bug X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jun 2014 08:20:18 -0000 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit On 2014年06月03日 15:13, Wenlin Kang wrote: > On 2014年06月03日 11:30, Saul Wold wrote: >> On 06/02/2014 06:55 PM, Wenlin Kang wrote: >>> For svn source, when download a revsion on branches, if the download >>> revsion < the branch created time revsion, then it will fail. >>> >> >>> The detail description reference the Yocto Project bugzilla, please >>> see: >>> https://bugzilla.yoctoproject.org/show_bug.cgi?id=6258 >>> >>> Signed-off-by: Wenlin Kang >>> --- >>> lib/bb/fetch2/svn.py | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/lib/bb/fetch2/svn.py b/lib/bb/fetch2/svn.py >>> index 8847461..75e21df 100644 >>> --- a/lib/bb/fetch2/svn.py >>> +++ b/lib/bb/fetch2/svn.py >>> @@ -98,7 +98,8 @@ class Svn(FetchMethod): >>> suffix = "" >>> if ud.revision: >>> options.append("-r %s" % ud.revision) >>> - suffix = "@%s" % (ud.revision) >>> + #follow this line can make the fetch fail when download a revsion >>> on branches if the download revsion < the branch created time revsion. >>> + #suffix = "@%s" % (ud.revision) >>> >> Will this cause other failures if there versions requests at a >> specific revision? can you detail how you tested this? > For a specific revsion download, I also do test, but I don't see > failure now. > My test follow, you can reference it. > > First, you need to create a svn server, eg, my is svnroot > $svnadmin create ~/workspace/svnroot > > Second, on the client side do: > $mkdir -p ~/workspace/svntest > $cd ~/workspace/svntest > $mkdir -p test/{trunk,branches,tag} > $mkdir -p test/trunk/tdir0/tdir1/tdir2 > $touch test/trunk/{hello.c} > $touch test/trunk/tdir0/tdir1/tdir2/test2.c > $touch test/trunk/tdir0/tdir1/test1.c > $touch test/trunk/tdir0/test0.c > > $svn import -m "create the project test" test/ > svn://xxx.xxx.xxx.xxx/svnroot/test > > Then, do some commit,... > Such, we now get "r15" > > $svn cp -m "create a branch test_debug-1.0" > svn://xxx.xxx.xxx.xxx/svnroot/test/trunk > svn://xxx.xxx.xxx.xxx/svnroot/test/branches/test_debug-1.0 > > Now, we create a bb file(eg, mytest.bb) to down "tdir1" with the > verion < test_debug-1.0 created time version, eg, download r12 > in bb file has: > SRCREV = "12" > SRC_URI = > "svn://xxx.xxx.xxx.xxx/svnroot/test/branches/test_debug-1.0;module=test0/tdir1" Replace "module=test0/tdir1" with "module=tdir0/tdir1" //Wenlin > > Last, run fetch for mytest.bb >> >> >>> if command == "fetch": >>> svncmd = "%s co %s %s://%s/%s%s %s" % (ud.basecmd, " >>> ".join(options), proto, svnroot, ud.module, suffix, ud.module) >>> >> >> > > -- Thanks, Wenlin Kang