Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Yao Xinpan <yaoxp@cn.fujitsu.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] nfs-utils: fix the --with-statdpath= flag
Date: Wed, 18 Jun 2014 08:38:40 -0700	[thread overview]
Message-ID: <53A1B280.1030303@linux.intel.com> (raw)
In-Reply-To: <1403081651-15505-1-git-send-email-yaoxp@cn.fujitsu.com>

On 06/18/2014 01:54 AM, Yao Xinpan wrote:
> if --with-statdpath= is not the default value, will happen the following questions:
> 'Failed to open directory sm: No such file or directory'.
>
> Nfs community has fixed this bug.
> URL: 'http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=3b1457d219ceb1058d44bacc657581f13437ae40#patch1'
>
> Signed-off-by: Yao Xinpan <yaoxp@cn.fujitsu.com>
> ---
>   .../0001-statd-fixed-the-with-statdpath-flag.patch | 40 ++++++++++++++++++++++
>   .../nfs-utils/nfs-utils_1.3.0.bb                   |  1 +
>   2 files changed, 41 insertions(+)
>   create mode 100644 meta/recipes-connectivity/nfs-utils/nfs-utils/0001-statd-fixed-the-with-statdpath-flag.patch
>
> diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils/0001-statd-fixed-the-with-statdpath-flag.patch b/meta/recipes-connectivity/nfs-utils/nfs-utils/0001-statd-fixed-the-with-statdpath-flag.patch
> new file mode 100644
> index 0000000..59a0935
> --- /dev/null
> +++ b/meta/recipes-connectivity/nfs-utils/nfs-utils/0001-statd-fixed-the-with-statdpath-flag.patch
> @@ -0,0 +1,40 @@
> +From 3b1457d219ceb1058d44bacc657581f13437ae40 Mon Sep 17 00:00:00 2001
> +From: Steve Dickson <steved@redhat.com>
> +Date: Tue, 17 Jun 2014 13:28:53 -0400
> +Subject: [PATCH] statd: fixed the --with-statdpath= flag
> +
> +Create the given path set with --with-statdpath
> +

You also need to include a Upstream-Status: Tag in this .patch file, 
please see the Commit and Patch Comment Guildlines:

http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

> +Signed-off-by: chendt.fnst@cn.fujitsu.com
> +Reported-by: yaoxp@cn.fujitsu.com
> +Signed-off-by: Steve Dickson <steved@redhat.com>
> +---
> + Makefile.am | 10 +++++-----
> + 1 file changed, 5 insertions(+), 5 deletions(-)
> +
> +diff --git a/Makefile.am b/Makefile.am
> +index ae7cd16..5824adc 100644
> +--- a/Makefile.am
> ++++ b/Makefile.am
> +@@ -54,13 +54,13 @@ install-data-hook:
> + 	touch $(DESTDIR)$(statedir)/xtab; chmod 644 $(DESTDIR)$(statedir)/xtab
> + 	touch $(DESTDIR)$(statedir)/etab; chmod 644 $(DESTDIR)$(statedir)/etab
> + 	touch $(DESTDIR)$(statedir)/rmtab; chmod 644 $(DESTDIR)$(statedir)/rmtab
> +-	mkdir -p $(DESTDIR)$(statedir)/sm $(DESTDIR)$(statedir)/sm.bak
> +-	touch $(DESTDIR)$(statedir)/state
> +-	chmod go-rwx $(DESTDIR)$(statedir)/sm $(DESTDIR)$(statedir)/sm.bak $(DESTDIR)$(statedir)/state
> +-	-chown $(statduser) $(DESTDIR)$(statedir)/sm $(DESTDIR)$(statedir)/sm.bak $(DESTDIR)$(statedir)/state
> ++	mkdir -p $(DESTDIR)$(statdpath)/sm $(DESTDIR)$(statdpath)/sm.bak
> ++	touch $(DESTDIR)$(statdpath)/state
> ++	chmod go-rwx $(DESTDIR)$(statdpath)/sm $(DESTDIR)$(statdpath)/sm.bak $(DESTDIR)$(statdpath)/state
> ++	-chown $(statduser) $(DESTDIR)$(statdpath)/sm $(DESTDIR)$(statdpath)/sm.bak $(DESTDIR)$(statdpath)/state
> +
> + uninstall-hook:
> + 	rm $(DESTDIR)$(statedir)/xtab
> + 	rm $(DESTDIR)$(statedir)/etab
> + 	rm $(DESTDIR)$(statedir)/rmtab
> +-	rm $(DESTDIR)$(statedir)/state
> ++	rm $(DESTDIR)$(statdpath)/state
> +--
> +1.8.4.2
> +
> diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.0.bb b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.0.bb
> index 8575647..c813d7f 100644
> --- a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.0.bb
> +++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.0.bb
> @@ -30,6 +30,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/nfs-utils/${PV}/nfs-utils-${PV}.tar.x
>              file://nfs-mountd.service \
>              file://nfs-statd.service \
>              file://nfs-utils-Do-not-pass-CFLAGS-to-gcc-while-building.patch \
> +           file://0001-statd-fixed-the-with-statdpath-flag.patch \
>   "
>
>   SRC_URI[md5sum] = "6e93a7997ca3a1eac56bf219adab72a8"
>


  reply	other threads:[~2014-06-18 15:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-18  8:54 [PATCH] nfs-utils: fix the --with-statdpath= flag Yao Xinpan
2014-06-18 15:38 ` Saul Wold [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-06-20  6:47 Yao Xinpan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A1B280.1030303@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=yaoxp@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox