Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Kang Kai <Kai.Kang@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 0/5] Update iptables runtime recommends and add default init scripts and configs
Date: Tue, 24 Jun 2014 09:57:46 +0800	[thread overview]
Message-ID: <53A8DB1A.7060106@windriver.com> (raw)
In-Reply-To: <CAJTo0LbT8HseE1T+tTCTcbr59rwjZ1zU_rDFnaQUNpqL7oDagg@mail.gmail.com>

On 2014年06月23日 18:44, Burton, Ross wrote:
>> Kai Kang (5):
>>    iptables: update RRECOMMENDS
>>    iptables: add init script and configure file
>>    iptables: update init script and bb file
> Squash these so there's a single commit that adds and integrates a
> working init script.

Though there is small change for init script, I still want to keep it 
that make clear which part is our modification.

I prefer to squash

iptables: update RRECOMMENDS
iptables: update init script and bb file

and keep
iptables: add init script and configure file




>
>>    iptables: add default rules
>>    iptables: update rules for ip6tables
> Ditto, squash these into a single commit.

I prefer to keep them too.

Regards,
Kai

>
> Ross
>
>


-- 
Regards,
Neil | Kai Kang



      reply	other threads:[~2014-06-24  1:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-23  2:32 [PATCH 0/5] Update iptables runtime recommends and add default init scripts and configs Kai Kang
2014-06-23  2:32 ` [PATCH 1/5] iptables: update RRECOMMENDS Kai Kang
2014-06-24  6:11   ` Anders Darander
2014-06-25  6:27     ` Kang Kai
2014-06-23  2:32 ` [PATCH 2/5] iptables: add init script and configure file Kai Kang
2014-06-23  2:32 ` [PATCH 3/5] iptables: add default rules Kai Kang
2014-06-23 10:42   ` Burton, Ross
2014-06-24  1:38     ` Kang Kai
2014-06-24  6:06       ` Anders Darander
2014-06-25  6:43         ` Kang Kai
2014-06-23  2:32 ` [PATCH 4/5] iptables: update rules for ip6tables Kai Kang
2014-06-23  2:32 ` [PATCH 5/5] iptables: update init script and bb file Kai Kang
2014-06-23 11:44   ` Anders Darander
2014-06-24  1:49     ` Kang Kai
2014-06-24  6:01       ` Anders Darander
2014-06-25  6:46         ` Kang Kai
2014-06-23 10:44 ` [PATCH 0/5] Update iptables runtime recommends and add default init scripts and configs Burton, Ross
2014-06-24  1:57   ` Kang Kai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A8DB1A.7060106@windriver.com \
    --to=kai.kang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox