Re: [RFC PATCH] base.bbclass: show git summary in BUILDCFG_HEADER

[Robert Yang <liezhi.yang@windriver.com>]

On 06/28/2014 10:27 AM, Robert Yang wrote:
> It was:
> meta
> meta-yocto
> meta-yocto-bsp    = "master:3a054dc27067efaae9150b465298d9c45d728f85"
>
> Now:
> meta
> meta-yocto
> meta-yocto-bsp    = "master:3a054dc base.bbclass: show git summary in BUILDCFG_HEADER"
>
> The benefit is that we can easily know the top commit info rather than
> query it again in the git repo.
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>   meta/classes/base.bbclass         |    2 +-
>   meta/classes/metadata_scm.bbclass |    6 ++++++
>   2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index c0d2c8ec8..f5abb88 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -244,7 +244,7 @@ def get_layers_branch_rev(d):
>       layers = (d.getVar("BBLAYERS", True) or "").split()
>       layers_branch_rev = ["%-17s = \"%s:%s\"" % (os.path.basename(i), \
>           base_get_metadata_git_branch(i, None).strip(), \
> -        base_get_metadata_git_revision(i, None)) \
> +        base_get_metadata_git_revision_and_summary(i, None)) \
>               for i in layers]
>       i = len(layers_branch_rev)-1
>       p1 = layers_branch_rev[i].find("=")
> diff --git a/meta/classes/metadata_scm.bbclass b/meta/classes/metadata_scm.bbclass
> index ba0edf9..133a647 100644
> --- a/meta/classes/metadata_scm.bbclass
> +++ b/meta/classes/metadata_scm.bbclass
> @@ -80,3 +80,9 @@ def base_get_metadata_git_revision(path, d):
>               return rev
>       return "<unknown>"
>
> +def base_get_metadata_git_revision_and_summary(path, d):
> +    f = os.popen("cd %s; git log -n 1 --abbrev-commit --pretty=oneline -- 2>&1" % path)
> +    data = f.readline()
> +    if f.close() is None:
> +            return data

Sorry, please drop this, lacks a rstrip() here.

// Robert

> +    return "<unknown>"
>