Re: [PATCH 1/2] libcroco: dont package /usr/bin/croco-0.6-config

[Ming Liu <ming.liu@windriver.com>]

On 07/04/2014 07:03 PM, Burton, Ross wrote:
> On 4 July 2014 11:54, Ming Liu <ming.liu@windriver.com> wrote:
>> +PACKAGE_PREPROCESS_FUNCS += "croco_package_preprocess"
>> +croco_package_preprocess () {
>> +       if [ -f ${PKGD}/${bindir}/croco-0.6-config ]; then
>> +               rm -f ${PKGD}/${bindir}/croco-0.6-config
>> +       fi
>> +}
> Erm, this is wrong.
>
> So croco-config is broken because the recipe doesn't inherit
> binconfig, to fix the paths and install the binary into libcroco-dev,
> where it belongs.  By not installing it into the package, you've
> broken anything that wants to build using croco-config inside a
> Yocto-generated image, such as the Build Appliance.
>
> Considering that the only recipe to depend on libcroco is librsvg, and
> that uses pkg-config instead of croco-config, then this recipe should
> also inherit binconfig-disabled to turn the config script into a "exit
> 1" no-op.
Yes, you are right! Thanks to correct me, I will send a V2 soon.

the best,
thank you
>
> Ross
>
>