From: akuster <akuster@mvista.com>
To: "Burton, Ross" <ross.burton@intel.com>,
Armin Kuster <akuster@mvista.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] lz4: update to latest version 119
Date: Tue, 08 Jul 2014 13:39:32 -0700 [thread overview]
Message-ID: <53BC5704.4020804@mvista.com> (raw)
In-Reply-To: <CAJTo0LYo+VSRkjKrbC3a5SRS0ixGdHXT=Ox0NCU1St7_mSm_9w@mail.gmail.com>
On 07/08/2014 03:15 AM, Burton, Ross wrote:
> On 7 July 2014 22:33, Armin Kuster <akuster@mvista.com> wrote:
>> -LIC_FILES_CHKSUM = "file://LICENSE;md5=2008d2325e11691e17fcaa3a6046f850"
>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=0b0d063f37a4477b54af2459477dcafd"
>
> Please add a comment in the commit message explaining why the checksum
> has changed.
ok, will do.
>
>> -SRC_URI = "svn://lz4.googlecode.com/svn/;module=trunk;protocol=http"
>> +SRC_URI = "https://github.com/Cyan4973/lz4/archive/${PV}.tar.gz"
>
> Github archives can't be trusted as they can be re-generated at any
> time by github (and the checksums will change). If upstream doesn't
> provide static tarballs then use the git fetcher and checkout the
> release tag.
>
Thanks for the info. I will look for a different solution.
- Armin
>> +S = "${WORKDIR}/${BPN}-${PV}"
>
> This is the default value.
>
> Ross
>
next prev parent reply other threads:[~2014-07-08 20:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 21:33 [PATCH 0/2] update lz4 and add maintainer Armin Kuster
2014-07-07 21:33 ` [PATCH 1/2] lz4: update to latest version 119 Armin Kuster
2014-07-08 10:15 ` Burton, Ross
2014-07-08 20:39 ` akuster [this message]
2014-07-07 21:33 ` [PATCH 2/2] lz4: Add self to maintainers list Armin Kuster
2014-07-08 14:30 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BC5704.4020804@mvista.com \
--to=akuster@mvista.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox