From: Saul Wold <sgw@linux.intel.com>
To: Ben Shelton <ben.shelton@ni.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/5] initscripts: bootmisc.sh: Make sysctl -p honor VERBOSE
Date: Wed, 16 Jul 2014 15:10:14 -0700 [thread overview]
Message-ID: <53C6F846.6080801@linux.intel.com> (raw)
In-Reply-To: <47a6fa0baf855ec8ffa563f01ea97a46e116648c.1405542432.git.ben.shelton@ni.com>
On 07/16/2014 01:59 PM, Ben Shelton wrote:
> From: Richard Tollerton <rich.tollerton@ni.com>
>
> busybox sysctl may lack the "-q" setting, so simulate it with redirects.
>
> Signed-off-by: Richard Tollerton <rich.tollerton@ni.com>
> Signed-off-by: Ben Shelton <ben.shelton@ni.com>
> ---
> meta/recipes-core/initscripts/initscripts-1.0/bootmisc.sh | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/initscripts/initscripts-1.0/bootmisc.sh b/meta/recipes-core/initscripts/initscripts-1.0/bootmisc.sh
> index 3b5a47f..5211824 100755
> --- a/meta/recipes-core/initscripts/initscripts-1.0/bootmisc.sh
> +++ b/meta/recipes-core/initscripts/initscripts-1.0/bootmisc.sh
> @@ -36,7 +36,12 @@ if [ -f "${SYSCTL_CONF}" ]
> then
> if [ -x "/sbin/sysctl" ]
> then
> - /sbin/sysctl -p "${SYSCTL_CONF}"
> + # busybox sysctl does not support -q
Will this work if procps's sysctl is used instead, I think it will but
wanted to verify it.
Sau!
> + VERBOSE_REDIR="1>/dev/null"
> + if [ "${VERBOSE}" != "no" ]; then
> + VERBOSE_REDIR="1>&1"
> + fi
> + eval /sbin/sysctl -p "${SYSCTL_CONF}" $VERBOSE_REDIR
> else
> echo "To have ${SYSCTL_CONF} applied during boot, install package <procps>."
> fi
>
next prev parent reply other threads:[~2014-07-16 22:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 20:59 [PATCH 0/5] Various fixes and improvements to initscripts Ben Shelton
2014-07-16 20:59 ` [PATCH 1/5] initscripts: bootmisc.sh: Make sysctl -p honor VERBOSE Ben Shelton
2014-07-16 22:10 ` Saul Wold [this message]
2014-07-17 15:02 ` Ben Shelton
2014-07-16 20:59 ` [PATCH 2/5] initscripts: save /etc/timestamp with seconds accuracy Ben Shelton
2014-07-16 22:05 ` Saul Wold
2014-07-17 15:00 ` Ben Shelton
2014-07-16 20:59 ` [PATCH 3/5] initscripts: parametrize random seed file location Ben Shelton
2014-07-16 20:59 ` [PATCH 4/5] initscripts: Use current date as an additional source of entropy Ben Shelton
2014-07-16 20:59 ` [PATCH 5/5] initscripts: make hostname.sh coreutils-compatible Ben Shelton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C6F846.6080801@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=ben.shelton@ni.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox