Re: [PATCH 1/1] perf: split package

[Chong Lu <Chong.Lu@windriver.com>]

On 07/17/2014 03:04 PM, Henning Heinold wrote:
> On Thu, Jul 17, 2014 at 02:58:46PM +0800, Chong Lu wrote:
>> On 07/17/2014 10:13 AM, Bruce Ashfield wrote:
>>> On Wed, Jul 16, 2014 at 9:43 PM, Chong Lu <Chong.Lu@windriver.com> wrote:
>>>> On 07/16/2014 09:04 PM, Bruce Ashfield wrote:
>>>>> On Wed, Jul 16, 2014 at 4:00 AM, Chong Lu <Chong.Lu@windriver.com> wrote:
>>>>>> Fix incorrect paths to split perf package.
>>>>> Can you elaborate here ? This commit message doesn't really tell us much.
>>>>> Why is the current split incorrect ? What is the symptom and result of the
>>>>> incorrect split ? Are the package contents the same after this change ?
>>>>>
>>>>> Bruce
>>>> Hi Bruce,
>>>>
>>>> Currently, perf can't split to perf-archive, perf-tests, perf-python and
>>>> perf-perl.
>>>> All files are included in perf package. For example, like perf-tests
>>>> package:
>>>> It generates files in '${exec_prefix}/libexec/perf-core/tests', not in
>>>> '${libdir}/perf/perf-core/tests'.
>>>> So I change the files paths to make split successfully.
>>> But that means, whether or not we like it, anything using perf has been using
>>> those "non splits" and getting everything when perf is installed.
>>>
>>> It's also might be in order to make the main perf package RDEPEND on
>>> the other three, to keep it consistent. Make it a ?= so it can be overridden,
>>> and then we can age it out over time.
>>>
>>> Bruce
>> Do you mean we should set RDEPENDS like:
>>      RDEPENDS_${PN} ?= "${PN}-archive ${PN}-tests ${PN}-python ${PN}-perl"
>>
>> In perf.bb file, we have RDEPENDS_${PN} += "elfutils", so I think we
>> should use
>>      RDEPENDS_${PN} += "${PN}-archive ${PN}-tests ${PN}-python ${PN}-perl"
>> to keep it consistent. Do you agree?
>>
>> Or, we can also revert following commit to make all files in perf package.
>>      commit 36c3e923df85e685b707fe6bd84b053a5e366fe4
>>      Author: Henning Heinold <henning@itconsulting-heinold.de>
>>      Date:   Mon Jun 9 23:21:29 2014 +0200
>>
>>          perf: split packging
>>
>> Best Regards
>> Chong
> Please do not destroy the following use case, which is using perf top
> WIHTOUT installing perl or python.
>
> Bye Henning
Hi Henning,

perf can't split to perf-archive, perf-tests, perf-python and perf-perl 
from your patch.
Currently, all files are in perf package.

BR
Chong