From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id 6D56C703CF for ; Mon, 21 Jul 2014 06:03:27 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.14.5/8.14.5) with ESMTP id s6L63R3X010958 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Sun, 20 Jul 2014 23:03:27 -0700 (PDT) Received: from [128.224.162.194] (128.224.162.194) by ALA-HCA.corp.ad.wrs.com (147.11.189.40) with Microsoft SMTP Server id 14.3.169.1; Sun, 20 Jul 2014 23:03:26 -0700 Message-ID: <53CCAD21.8050301@windriver.com> Date: Mon, 21 Jul 2014 14:03:13 +0800 From: Hongxu Jia User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: References: <24a0f777e3517a0365315cc1d311ba9d686c80a2.1405917574.git.hongxu.jia@windriver.com> In-Reply-To: <24a0f777e3517a0365315cc1d311ba9d686c80a2.1405917574.git.hongxu.jia@windriver.com> Cc: saul.wold@intel.com Subject: Re: [PATCH 1/1] add checking to standardize how .bbappend files do FILESEXTRAPATHS X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2014 06:03:30 -0000 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit I think it is more reasonable to move the checking to insance.bbclass rather than create a new bbclass. Please drop this, V2 incoming. //Hongxu On 07/21/2014 01:34 PM, Hongxu Jia wrote: > When adding patches or config files from bbappend files, it requires > the use of FILESEXTRAPATHS, which has been an issue and failure point > for people starting to work with bitbake and oe-core. > > We add checking to standardize how to use FILESEXTRAPATHS. Only the > format of: > FILESEXTRAPATHS_append := ${THISDIR}/Your_Files_Path or > FILESEXTRAPATHS_prepend := ${THISDIR}/Your_Files_Path > is acceptable. > > [YOCTO #5412] > > Signed-off-by: Hongxu Jia > --- > meta/classes/base.bbclass | 1 + > meta/classes/filesextrapaths_check.bbclass | 10 ++++++++++ > meta/classes/utils.bbclass | 2 ++ > meta/conf/bitbake.conf | 2 ++ > 4 files changed, 15 insertions(+) > create mode 100644 meta/classes/filesextrapaths_check.bbclass > > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass > index 8114cf6..be8400a 100644 > --- a/meta/classes/base.bbclass > +++ b/meta/classes/base.bbclass > @@ -9,6 +9,7 @@ inherit utils > inherit utility-tasks > inherit metadata_scm > inherit logging > +inherit filesextrapaths_check > > OE_IMPORTS += "os sys time oe.path oe.utils oe.data oe.package oe.packagegroup oe.sstatesig oe.lsb oe.cachedpath" > OE_IMPORTS[type] = "list" > diff --git a/meta/classes/filesextrapaths_check.bbclass b/meta/classes/filesextrapaths_check.bbclass > new file mode 100644 > index 0000000..6863e0c > --- /dev/null > +++ b/meta/classes/filesextrapaths_check.bbclass > @@ -0,0 +1,10 @@ > +python __anonymous() { > + # Checking ${FILESEXTRAPATHS} > + extrapaths = (d.getVar("FILESEXTRAPATHS", True) or "") > + if '__default' not in extrapaths.split(":"): > + msg = "Please assign FILESEXTRAPATHS with the format of:\n" > + msg += " FILESEXTRAPATHS_append := ${THISDIR}/Your_Files_Path or\n" > + msg += " FILESEXTRAPATHS_prepend := ${THISDIR}/Your_Files_Path\n" > + msg += "in your bbappend file\n" > + bb.fatal(msg) > +} > diff --git a/meta/classes/utils.bbclass b/meta/classes/utils.bbclass > index 0ee13e0..0f2a484 100644 > --- a/meta/classes/utils.bbclass > +++ b/meta/classes/utils.bbclass > @@ -312,6 +312,8 @@ def explode_deps(s): > def base_set_filespath(path, d): > filespath = [] > extrapaths = (d.getVar("FILESEXTRAPATHS", True) or "") > + # Remove default flag which was used for checking > + extrapaths = extrapaths.replace("__default:", "") > # Don't prepend empty strings to the path list > if extrapaths != "": > path = extrapaths.split(":") + path > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > index f4870d5..6a0cf7a 100644 > --- a/meta/conf/bitbake.conf > +++ b/meta/conf/bitbake.conf > @@ -311,6 +311,8 @@ FILES_${PN}-locale = "${datadir}/locale" > FILE_DIRNAME = "${@os.path.dirname(d.getVar('FILE'))}" > # FILESPATH is set in base.bbclass > #FILESPATH = "${FILE_DIRNAME}/${PF}:${FILE_DIRNAME}/${P}:${FILE_DIRNAME}/${PN}:${FILE_DIRNAME}/${BP}:${FILE_DIRNAME}/${BPN}:${FILE_DIRNAME}/files:${FILE_DIRNAME}" > +# This default was only used for checking > +FILESEXTRAPATHS ?= "__default:" > > ################################################################## > # General work and output directories for the build system.