Re: [PATCH 01/20] udev-cache: Compress the cache

[Randy MacLeod <randy.macleod@windriver.com>]

On 14-08-04 02:40 PM, Ben Shelton wrote:
> From: Richard Tollerton <rich.tollerton@ni.com>
>
> $DEVCACHE is observed to be 100k uncompressed; compressing it reduces
> its size to ~5k.
>
> Natinst-Rally-ID: TA44427
> Acked-by: Gratian Crisan <gratian.crisan@ni.com>
> Natinst-ReviewBoard-ID: 58620


This is a good series of patches; thanks for sending them.

It would be nice if you could remove your company's ID tags
from the commit log. For example, you create and use could use
a YP bugzilla ID ( https://bugzilla.yoctoproject.org/ ) and
then match that up in your internal process.

Thanks,
../Randy


> Signed-off-by: Richard Tollerton <rich.tollerton@ni.com>
> ---
>   meta/recipes-core/udev/udev/init               | 2 +-
>   meta/recipes-core/udev/udev/udev-cache         | 2 +-
>   meta/recipes-core/udev/udev/udev-cache.default | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-core/udev/udev/init b/meta/recipes-core/udev/udev/init
> index f2c84d5..1e69861 100644
> --- a/meta/recipes-core/udev/udev/init
> +++ b/meta/recipes-core/udev/udev/init
> @@ -69,7 +69,7 @@ case "$1" in
>   		    readfiles /etc/udev/cache.data
>   		    OLDDATA="$READDATA"
>   		    if [ "$OLDDATA" = "$NEWDATA" ]; then
> -                            (cd /; tar xf $DEVCACHE > /dev/null 2>&1)
> +                            (cd /; tar xzf $DEVCACHE > /dev/null 2>&1)
>                               not_first_boot=1
>                               [ "$VERBOSE" != "no" ] && echo "udev: using cache file $DEVCACHE"
>                               [ -e /dev/shm/udev.cache ] && rm -f /dev/shm/udev.cache
> diff --git a/meta/recipes-core/udev/udev/udev-cache b/meta/recipes-core/udev/udev/udev-cache
> index db5a513..3769062 100644
> --- a/meta/recipes-core/udev/udev/udev-cache
> +++ b/meta/recipes-core/udev/udev/udev-cache
> @@ -25,7 +25,7 @@ fi
>
>   if [ "$DEVCACHE" != "" -a -e /dev/shm/udev.cache ]; then
>   	echo "Populating dev cache"
> -	(cd /; tar cf "$DEVCACHE" dev)
> +	(cd /; tar czf "$DEVCACHE" dev)
>   	mv /dev/shm/udev.cache /etc/udev/cache.data
>   fi
>
> diff --git a/meta/recipes-core/udev/udev/udev-cache.default b/meta/recipes-core/udev/udev/udev-cache.default
> index 2093336..909ec87 100644
> --- a/meta/recipes-core/udev/udev/udev-cache.default
> +++ b/meta/recipes-core/udev/udev/udev-cache.default
> @@ -1,5 +1,5 @@
>   # Default for /etc/init.d/udev
>
>   # Comment this out to disable device cache
> -DEVCACHE="/etc/dev.tar"
> +DEVCACHE="/etc/dev.tar.gz"
>   PROBE_PLATFORM_BUS="yes"
>


-- 
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350