Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Andreas Oberritter <obi@opendreambox.org>
To: "Khan, Yasir" <Yasir_Khan@mentor.com>,
	 "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2] wpa-supplicant: use PACKAGECONFIG for ssl selection
Date: Wed, 06 Aug 2014 15:32:26 +0200	[thread overview]
Message-ID: <53E22E6A.5030204@opendreambox.org> (raw)
In-Reply-To: <428317DA8188854B9B82598D29DA15E24E0D30A3@EU-MBX-02.mgc.mentorg.com>

Hello Yasir,

On 06.08.2014 14:51, Khan, Yasir wrote:
>>> +PACKAGECONFIG ??= "gnutls"
>>> +PACKAGECONFIG[gnutls] = ",,gnutls"
>> I think libgcrypt should be added here and removed above. At least it
>> doesn't appear to be a runtime dependency when building with openssl, so
>> I suppose it's a gnutls thing.
> 
> As per commit 1fe8f631f, gnutls doesn't depend on libgcrypt anymore but wpa-supplicant does. So I guess it should be in the DEPENDS. 

It does, if built with gnutls, but not with openssl. Look for -lgcrypt
in wpa_supplicant/Makefile, if you want to assure yourself.

> I've made other changes as you've pointed out. I will be sending another patch shortly.

Thanks,
Andreas


      reply	other threads:[~2014-08-06 13:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-05 19:37 [PATCH v2] wpa-supplicant: use PACKAGECONFIG for ssl selection Yasir Khan
2014-08-06  8:23 ` Martin Jansa
2014-08-06 11:21 ` Andreas Oberritter
2014-08-06 12:51   ` Khan, Yasir
2014-08-06 13:32     ` Andreas Oberritter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53E22E6A.5030204@opendreambox.org \
    --to=obi@opendreambox.org \
    --cc=Yasir_Khan@mentor.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox