Re: [PATCH] coreutils: drop patch that unconditionally mangles manpages

[Paul Gortmaker <paul.gortmaker@windriver.com>]

On 14-08-07 01:33 AM, Koen Kooi wrote:
> 
> Op 6 aug. 2014, om 22:38 heeft Paul Gortmaker <paul.gortmaker@windriver.com> het volgende geschreven:
> 
>> commit 841ec528ec04e64bd09ff10f8d9ad2d6e3aac05d ("coreutils: update
>> to upstream version 9.21") added a patch which bypassed the check
>> for perl and hence defaults to using the dummy man page for all
>> of the coreutils manpages.  This results in all manpages looking like:
>>
>>  NAME
>>       chmod - a GNU coreutils 8.22 program
>>
>>  DESCRIPTION
>>       OOOPS!   Due to the lack of perl on the build system, we were unable to
>>       create a proper manual page for chmod.
>>
>> It is unclear why the test was disabled, but since it clearly
>> causes the manpages to be useless, we need to drop this patch.
> 
> That all might be true, but DEPENDS doesn't list 'perl' or 'perl-native', so this commit is wrong.

Wrong might be overstated.  The patch unconditionally disables a
_check_ for perl.  So if perl is there, it is used; if it is absent,
it is not.  Given that there really is no excuse for shipping
broken manpages, one could argue that a DEPENDS on perl-native
is sensible, and if that is what it takes to get the broken patch
dropped, I'll add one.

P.
--

>