Re: [PATCH] Remove "SRC_URI_OVERRIDES_PACKAGE_ARCH = 0" from tslib.bb

[Saul Wold <sgw@linux.intel.com>]

On 08/09/2014 06:17 AM, Robert P. J. Day wrote:
> On Fri, 8 Aug 2014, Saul Wold wrote:
>
>> On 08/08/2014 12:31 PM, Robert P. J. Day wrote:
>>>
>>> Given that there are no machine-specific files for the tslib recipe
>>> anymore, might as well remove this line.
>>>
>>
>> Robert,
>>
>> Can you please review the commit guidelines
>>
>> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
>>
>> The summary line should be in the form of
>> tslib: Remove ...
>
>    serious question -- how does one identify the "primary item" under
> consideration if it's scattered over several files. recently, i
> submitted a patch to remove a few references to "do_package_write",
> a deleted task. the existing references under meta/:
>
Great question actually and maybe this needs clarification in the Wiki.

Ideally if it's an atomic change around a "primary idea" than that's the 
focus. Sometimes with refactorings we do bulk and sometime it's 
individual, depends on if the small changes will cause bisect failures.

> conf/documentation.conf:do_package_write[doc] = "Creates the actual packages and places them in the Package Feed area"
> recipes-core/meta/meta-ide-support.bb:do_populate_ide_support[recrdeptask] = "do_package_write"
> recipes-core/meta/package-index.bb:do_package_write[noexec] = "1"
> recipes-devtools/installer/adt-installer_1.0.bb:do_package_write[noexec] = "1"
>
>    i'm assuming, in this case, the primary item would be
> "do_package_write"?
>
Yes, that would be the primary idea in this case.

Sau!

> rday
>