Re: [PATCH 1/2] squashfs-tools: Enable LZO support

[Mike Looijmans <mike.looijmans@topic.nl>]

On 08/11/2014 12:33 PM, Richard Purdie wrote:
> On Mon, 2014-08-11 at 12:11 +0200, Mike Looijmans wrote:
>> For systems looking for speed rather than size (e.g. booting from serial NOR
>> flash) LZO is usually a good tradeoff, and usually boots faster than gzip
>> or even an uncompressed filesystem.
>>
>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>> ---
>>   .../squashfs-tools/squashfs-tools_4.2.bb           |    4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/squashfs-tools/squashfs-tools_4.2.bb b/meta/recipes-devtools/squashfs-tools/squashfs-tools_4.2.bb
>> index 57400cd..1ded2c9 100644
>> --- a/meta/recipes-devtools/squashfs-tools/squashfs-tools_4.2.bb
>> +++ b/meta/recipes-devtools/squashfs-tools/squashfs-tools_4.2.bb
>> @@ -6,7 +6,7 @@ LICENSE = "GPL-2 & PD"
>>   LIC_FILES_CHKSUM = "file://../COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
>>                       file://../../7zC.txt;beginline=12;endline=16;md5=2056cd6d919ebc3807602143c7449a7c \
>>                      "
>> -DEPENDS = "attr zlib xz"
>> +DEPENDS = "attr zlib xz lzo"
>>   PR = "r2"
>>
>>   SRC_URI = "${SOURCEFORGE_MIRROR}/squashfs/squashfs${PV}.tar.gz;name=squashfs \
>> @@ -27,7 +27,7 @@ S = "${WORKDIR}/squashfs${PV}/squashfs-tools"
>>   # EXTRA_OEMAKE is typically: -e MAKEFLAGS=
>>   # the -e causes problems as CFLAGS is modified in the Makefile, so
>>   # we redefine EXTRA_OEMAKE here
>> -EXTRA_OEMAKE = "MAKEFLAGS= LZMA_SUPPORT=1 LZMA_DIR=../.. XZ_SUPPORT=1"
>> +EXTRA_OEMAKE = "MAKEFLAGS= LZMA_SUPPORT=1 LZMA_DIR=../.. LZO_SUPPORT=1 XZ_SUPPORT=1"
>>
>>   do_compile() {
>>           oe_runmake mksquashfs
>
> The patch is good but its against 4.2, 4.3 is now in master. Could you
> resend against master please?

Hmm, I've been using 4.2 for years, and just now they release a new version. 
Funky timing.

> Also, could you resend 2/2 without the whitespace changes (put them in a
> separate patch).

Now you mention it, yeah, I probably forgot to set my editor's settings correctly.

I'll create new patches, it'll take a few days because I'll have to test them 
first, and my environment is a few weeks behind on master because of all the 
changes lately that break all kinds of existing recipes.

Mike.


Met vriendelijke groet / kind regards,

Mike Looijmans

TOPIC Embedded Systems
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: (+31) (0) 499 33 69 79
Telefax:  (+31) (0) 499 33 69 70
E-mail: mike.looijmans@topic.nl
Website: www.topic.nl

Please consider the environment before printing this e-mail

Bezoek ons op 9 en 10 september tijdens Technology for Health Den Bosch (stand 53)
http://www.technologyforhealth.nl