From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Yang.Shi@windriver.com>
Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13])
	by mail.openembedded.org (Postfix) with ESMTP id 18B3E65DEB
	for <openembedded-core@lists.openembedded.org>;
	Tue, 19 Aug 2014 18:36:20 +0000 (UTC)
Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com
	[147.11.189.40])
	by mail1.windriver.com (8.14.9/8.14.5) with ESMTP id s7JIaLd9025741
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL)
	for <openembedded-core@lists.openembedded.org>;
	Tue, 19 Aug 2014 11:36:21 -0700 (PDT)
Received: from [147.11.216.83] (147.11.216.83) by ALA-HCA.corp.ad.wrs.com
	(147.11.189.50) with Microsoft SMTP Server id 14.3.174.1;
	Tue, 19 Aug 2014 11:36:21 -0700
Message-ID: <53F39924.3030802@windriver.com>
Date: Tue, 19 Aug 2014 11:36:20 -0700
From: Yang Shi <yang.shi@windriver.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
	rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: Bruce Ashfield <bruce.ashfield@windriver.com>,
	<openembedded-core@lists.openembedded.org>
References: <1408472025-4777-1-git-send-email-yang.shi@windriver.com>
	<53F396B9.3050608@windriver.com>
In-Reply-To: <53F396B9.3050608@windriver.com>
Subject: Re: [PATCH] kernel: Prevent from installing so files into source dir
X-BeenThere: openembedded-core@lists.openembedded.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Patches and discussions about the oe-core layer
	<openembedded-core.lists.openembedded.org>
List-Unsubscribe: <http://lists.openembedded.org/mailman/options/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=unsubscribe>
List-Archive: <http://lists.openembedded.org/pipermail/openembedded-core/>
List-Post: <mailto:openembedded-core@lists.openembedded.org>
List-Help: <mailto:openembedded-core-request@lists.openembedded.org?subject=help>
List-Subscribe: <http://lists.openembedded.org/mailman/listinfo/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Aug 2014 18:36:24 -0000
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit

On 8/19/2014 11:26 AM, Bruce Ashfield wrote:
> On 14-08-19 02:13 PM, Yang Shi wrote:
>> vdso build could generate so files, avoid installing such so files 
>> into kernel
>> source dir.
>
> Looks good. I never did hit this myself, but this will cover my .so.dbg
> case, and the non debug variant.
>
> That being said, you mentioned that we get a QA error on the .so file
> (about it being stripped) .. that would be useful to have captured in
> this commit log.

OK, V2 is going to be sent soon with the error message captured in the 
commit log.

Thanks,
Yang

>
> Bruce
>
>>
>> Signed-off-by: Yang Shi <yang.shi@windriver.com>
>> ---
>>   meta/classes/kernel.bbclass | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index 819c302..435b6f0 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -253,7 +253,7 @@ kernel_do_install() {
>>       # dir. This ensures the original Makefiles are used and not the
>>       # redirecting Makefiles in the build directory.
>>       #
>> -    find . -depth -not -name "*.cmd" -not -name "*.o" -not -name 
>> "*.so.dbg" -not -path "./Documentation*" -not -path "./source*" -not 
>> -path "./.*" -print0 | cpio --null -pdlu $kerneldir
>> +    find . -depth -not -name "*.cmd" -not -name "*.o" -not -name 
>> "*.so.dbg" -not -name "*.so" -not -path "./Documentation*" -not -path 
>> "./source*" -not -path "./.*" -print0 | cpio --null -pdlu $kerneldir
>>       cp .config $kerneldir
>>       if [ "${S}" != "${B}" ]; then
>>           pwd="$PWD"
>>
>
>
>