Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Hongxu Jia <hongxu.jia@windriver.com>
To: Chen Qi <Qi.Chen@windriver.com>,
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] sudo: remove volatile configuration file
Date: Thu, 21 Aug 2014 17:28:49 +0800	[thread overview]
Message-ID: <53F5BBD1.1050203@windriver.com> (raw)
In-Reply-To: <7f14cd53dd0190a96a4f4c3a7f1355f973405aa3.1408604060.git.Qi.Chen@windriver.com>

We should remove volatiles.99_sudo file also.

//Hongxu

On 08/21/2014 02:55 PM, Chen Qi wrote:
> The new version of sudo has fixed the problem and will create the
> directory if it doesn't exist. So the configuration file is no longer
> needed.
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>   meta/recipes-extended/sudo/sudo_1.8.10p3.bb |    7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/meta/recipes-extended/sudo/sudo_1.8.10p3.bb b/meta/recipes-extended/sudo/sudo_1.8.10p3.bb
> index 46d4781..4c53032 100644
> --- a/meta/recipes-extended/sudo/sudo_1.8.10p3.bb
> +++ b/meta/recipes-extended/sudo/sudo_1.8.10p3.bb
> @@ -2,7 +2,7 @@ require sudo.inc
>   
>   SRC_URI = "http://ftp.sudo.ws/sudo/dist/sudo-${PV}.tar.gz \
>              ${@bb.utils.contains('DISTRO_FEATURES', 'pam', '${PAM_SRC_URI}', '', d)} \
> -           file://volatiles.99_sudo"
> +          "
>   
>   PAM_SRC_URI = "file://sudo.pam"
>   
> @@ -22,9 +22,6 @@ do_install_append () {
>   	chmod 4111 ${D}${bindir}/sudo
>   	chmod 0440 ${D}${sysconfdir}/sudoers
>   
> -	# Explicitly remove the ${localstatedir}/run directory as we can
> -	# manage it by a configuration file under ${sysconfdir}/default/volatiles/
> +	# Explicitly remove the ${localstatedir}/run directory to avoid QA error
>   	rmdir -p --ignore-fail-on-non-empty ${D}${localstatedir}/run/sudo
> -	install -d ${D}/${sysconfdir}/default/volatiles
> -	install -m 644 ${WORKDIR}/volatiles.99_sudo ${D}/${sysconfdir}/default/volatiles/99_sudo
>   }



      reply	other threads:[~2014-08-21  9:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-21  6:55 [PATCH 0/1] sudo: remove volatile configuration file Chen Qi
2014-08-21  6:55 ` [PATCH 1/1] " Chen Qi
2014-08-21  9:28   ` Hongxu Jia [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F5BBD1.1050203@windriver.com \
    --to=hongxu.jia@windriver.com \
    --cc=Qi.Chen@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox