From: "Usman, Fahad" <Fahad_Usman@mentor.com>
To: Khem Raj <raj.khem@gmail.com>, Christopher Larson <clarson@kergoth.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] logrotate: obey our flags
Date: Tue, 26 Aug 2014 12:43:38 +0500 [thread overview]
Message-ID: <53FC3AAA.7030700@mentor.com> (raw)
In-Reply-To: <20140825175147.GB25050@haswell>
On 08/25/2014 10:51 PM, Khem Raj wrote:
>>>> + LFS= \
>>>> > > >+ OS_NAME='${OS_NAME}' \
>>>> > > >+ \
>>>> > > >+ 'CC=${CC}' \
>>> > >
>>> > >hmmm CC may have spaces in it so you might need 'CC="${CC}"' or somesuch
>> >
>> >
>> >Nope, the whole CC=${CC} argument is already quoted, note the single quotes
>> >around it. Those quotes mean the entire CC=${CC} bit ends up in the
>> >appropriate argument for make, so there's no need to quote the value alone.
> What happens inside makefile is what I am concerned
> in case of python, IIRC it passed it but when CC was used it would
> freak out since CC now was a multiword str but then those were not inside makefiles
> if you have verified thats fine here then I am OK.
Just checked the CC do have spaces, and it works fine. I am re-sending
the patch with the fixed typo.
prev parent reply other threads:[~2014-08-26 7:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 16:22 [PATCH 1/2] logrotate: obey our flags Fahad Usman
2014-08-25 16:22 ` [PATCH 2/2] logrotate: add packageconfigs Fahad Usman
2014-08-27 15:52 ` Burton, Ross
2014-08-27 16:19 ` Christopher Larson
2014-08-25 16:30 ` [PATCH 1/2] logrotate: obey our flags Christopher Larson
2014-08-25 17:19 ` Khem Raj
2014-08-25 17:21 ` Christopher Larson
2014-08-25 17:51 ` Khem Raj
2014-08-26 7:43 ` Usman, Fahad [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FC3AAA.7030700@mentor.com \
--to=fahad_usman@mentor.com \
--cc=clarson@kergoth.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox