Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Laszlo Papp <lpapp@kde.org>,  openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] Add support for ccache builds with the SDK
Date: Fri, 29 Aug 2014 11:29:57 -0700	[thread overview]
Message-ID: <5400C6A5.6040001@linux.intel.com> (raw)
In-Reply-To: <1408720803-11737-1-git-send-email-lpapp@kde.org>


Might be a nit, but can you please follow the Commit Guildlines at
http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

The summary should include the filename or area of the fix

toolchain-script: Add ...

Also can you expand on the why this is needed?

Thanks
	Sau!

On 08/22/2014 08:20 AM, Laszlo Papp wrote:
> Signed-off-by: Laszlo Papp <lpapp@kde.org>
> ---
>   meta/classes/toolchain-scripts.bbclass | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/meta/classes/toolchain-scripts.bbclass b/meta/classes/toolchain-scripts.bbclass
> index 6cc8eba..60278d6 100644
> --- a/meta/classes/toolchain-scripts.bbclass
> +++ b/meta/classes/toolchain-scripts.bbclass
> @@ -19,6 +19,7 @@ toolchain_create_sdk_env_script () {
>   		EXTRAPATH="$EXTRAPATH:${SDKPATHNATIVE}${bindir_nativesdk}/${TARGET_ARCH}${TARGET_VENDOR}-$i"
>   	done
>   	echo 'export PATH=${SDKPATHNATIVE}${bindir_nativesdk}:${SDKPATHNATIVE}${bindir_nativesdk}/${TARGET_SYS}'$EXTRAPATH':$PATH' >> $script
> +	echo 'export CCACHE_PATH=${SDKPATHNATIVE}${bindir_nativesdk}:${SDKPATHNATIVE}${bindir_nativesdk}/${TARGET_SYS}'$EXTRAPATH':$CCACHE_PATH' >> $script
>   	echo 'export PKG_CONFIG_SYSROOT_DIR=$SDKTARGETSYSROOT' >> $script
>   	echo 'export PKG_CONFIG_PATH=$SDKTARGETSYSROOT'"$libdir"'/pkgconfig' >> $script
>   	echo 'export CONFIG_SITE=${SDKPATH}/site-config-'"${multimach_target_sys}" >> $script
> @@ -37,6 +38,7 @@ toolchain_create_tree_env_script () {
>   	rm -f $script
>   	touch $script
>   	echo 'export PATH=${STAGING_DIR_NATIVE}/usr/bin:${PATH}' >> $script
> +	echo 'export CCACHE_PATH=${STAGING_DIR_NATIVE}/usr/bin:${CCACHE_PATH}' >> $script
>   	echo 'export PKG_CONFIG_SYSROOT_DIR=${PKG_CONFIG_SYSROOT_DIR}' >> $script
>   	echo 'export PKG_CONFIG_PATH=${PKG_CONFIG_PATH}' >> $script
>   	echo 'export CONFIG_SITE="${@siteinfo_get_files(d)}"' >> $script
>


  parent reply	other threads:[~2014-08-29 18:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22 15:20 [PATCH] Add support for ccache builds with the SDK Laszlo Papp
2014-08-29 10:55 ` Laszlo Papp
2014-08-29 18:29 ` Saul Wold [this message]
2014-09-01 17:34   ` Laszlo Papp
2014-09-01 17:47     ` Laszlo Papp
2014-09-01 18:04       ` Otavio Salvador
2014-09-02  6:22         ` Fathi Boudra
2014-09-02  7:11           ` Richard Purdie
2014-09-02  9:03             ` Paul Barker
2014-09-09 15:02           ` Laszlo Papp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5400C6A5.6040001@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=lpapp@kde.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox