Re: [PATCH] package_rpm: Add %manifest support for spec generation.

[Mark Hatle <mark.hatle@windriver.com>]

On 8/29/14, 12:39 PM, Richard Purdie wrote:
> From: Ronan Le Martret <ronan@fridu.net>
>
> The manifest file allow custom smack security for a package.
>      https://wiki.tizen.org/wiki/Security/Application_installation_and_Manifest

I'm concerned with this simply because we're adding a very specific (non-oe) 
mechanism into the mix.

I'd prefer if there was simple a "perform this generic action, which can add to 
the .spec file"

The during the packaging (before writing the .spec) we can call the action and 
it can insert the %manifest if appropriate.

That can then be distribution defined and work with any arbitrary mechanisms.

--Mark

> Signed-off-by: Ronan Le Martret <ronan@fridu.net>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>
> diff --git a/meta/classes/package_rpm.bbclass b/meta/classes/package_rpm.bbclass
> index eecfcb2..0f565ac 100644
> --- a/meta/classes/package_rpm.bbclass
> +++ b/meta/classes/package_rpm.bbclass
> @@ -389,6 +389,8 @@ python write_specfile () {
>               else:
>                   bb.note("Creating RPM package for %s" % splitname)
>                   spec_files_top.append('%files')
> +                if localdata.getVar('MANIFESTFILES', True):
> +                    spec_files_top.append('%%manifest %s' %  localdata.getVar('MANIFESTFILES', True))
>                   spec_files_top.append('%defattr(-,-,-,-)')
>                   if file_list:
>                       bb.note("Creating RPM package for %s" % splitname)
> @@ -495,6 +497,8 @@ python write_specfile () {
>               bb.note("Not creating empty RPM package for %s" % splitname)
>           else:
>               spec_files_bottom.append('%%files -n %s' % splitname)
> +            if localdata.getVar('MANIFESTFILES', True):
> +                spec_files_bottom.append('%%manifest %s' %  localdata.getVar('MANIFESTFILES', True))
>               spec_files_bottom.append('%defattr(-,-,-,-)')
>               if file_list:
>                   bb.note("Creating RPM package for %s" % splitname)
>
>