From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id 1D3BC60E49 for ; Sat, 30 Aug 2014 05:23:47 +0000 (UTC) Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com [147.11.189.41]) by mail1.windriver.com (8.14.9/8.14.5) with ESMTP id s7U5NjFL014969 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 29 Aug 2014 22:23:45 -0700 (PDT) Received: from [128.224.162.181] (128.224.162.181) by ALA-HCB.corp.ad.wrs.com (147.11.189.41) with Microsoft SMTP Server id 14.3.174.1; Fri, 29 Aug 2014 22:23:44 -0700 Message-ID: <54015FDF.8070001@windriver.com> Date: Sat, 30 Aug 2014 13:23:43 +0800 From: Robert Yang User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Max Eliaser References: <1409331683.8504.1.camel@maxtothemax-Studio-XPS-8000> In-Reply-To: <1409331683.8504.1.camel@maxtothemax-Studio-XPS-8000> Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 8/9] bootchart2: no bashism in bootchartd.in X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Aug 2014 05:23:49 -0000 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit On 08/30/2014 01:01 AM, Max Eliaser wrote: > Would you be okay with me sending this one upstream? I think it's a > worthwhile modification. Yes, of course, thanks for sending. // Robert > > -Max > > On Wed, 2014-08-27 at 08:57 -0700, Robert Yang wrote: >> So use /bin/sh >> >> Signed-off-by: Robert Yang >> --- >> .../bootchart2/bootchartd-no-bashism.patch | 27 ++++++++++++++++++++ >> meta/recipes-devtools/bootchart2/bootchart2_git.bb | 6 +++-- >> 2 files changed, 31 insertions(+), 2 deletions(-) >> create mode 100644 meta/recipes-devtools/bootchart2/bootchart2/bootchartd-no-bashism.patch >> >> diff --git a/meta/recipes-devtools/bootchart2/bootchart2/bootchartd-no-bashism.patch b/meta/recipes-devtools/bootchart2/bootchart2/bootchartd-no-bashism.patch >> new file mode 100644 >> index 0000000..b013995 >> --- /dev/null >> +++ b/meta/recipes-devtools/bootchart2/bootchart2/bootchartd-no-bashism.patch >> @@ -0,0 +1,27 @@ >> +From ffb5bae5d588aaea6325623462a8070a04767196 Mon Sep 17 00:00:00 2001 >> +From: Robert Yang >> +Date: Thu, 14 Aug 2014 08:33:28 -0700 >> +Subject: [PATCH] bootchartd.in: no bashism >> + >> +No bashism in bootchartd.in, so use /bin/sh. >> + >> +Upstream-Status: Pending >> + >> +Signed-off-by: Robert Yang >> +--- >> + bootchartd.in | 2 +- >> + 1 file changed, 1 insertion(+), 1 deletion(-) >> + >> +diff --git a/bootchartd.in b/bootchartd.in >> +index a408bab..064f6a4 100755 >> +--- a/bootchartd.in >> ++++ b/bootchartd.in >> +@@ -1,4 +1,4 @@ >> +-#!/bin/bash >> ++#!/bin/sh >> + # >> + # Bootchart logger script >> + # Ziga Mahkovec >> +-- >> +1.7.9.5 >> + >> diff --git a/meta/recipes-devtools/bootchart2/bootchart2_git.bb b/meta/recipes-devtools/bootchart2/bootchart2_git.bb >> index 4116304..04fb901 100644 >> --- a/meta/recipes-devtools/bootchart2/bootchart2_git.bb >> +++ b/meta/recipes-devtools/bootchart2/bootchart2_git.bb >> @@ -91,8 +91,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=44ac4678311254db62edf8fd39cb8124" >> # one commit beyond 1.14.6 for a systemd-related bugfix >> PV = "0.14.6+git${SRCPV}" >> >> -SRC_URI = "git://github.com/mmeeks/bootchart.git" >> -SRC_URI += "file://bootchartd_stop.sh" >> +SRC_URI = "git://github.com/mmeeks/bootchart.git \ >> + file://bootchartd_stop.sh \ >> + file://bootchartd-no-bashism.patch \ >> + " >> >> SRCREV = "b65ed43b0ae832080fb728245de9ef1a4b48d8b5" >> >> -- >> 1.7.9.5 >> > > > >