From: ChenQi <Qi.Chen@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 25/26] run-postinsts.service: remove redundant line
Date: Wed, 3 Sep 2014 10:50:22 +0800 [thread overview]
Message-ID: <540681EE.9050602@windriver.com> (raw)
In-Reply-To: <CAJTo0LYODrmCZQbXMmjAAykNS2rgkHjY5ZL_hKF0NAU5+zQDcQ@mail.gmail.com>
On 09/03/2014 01:17 AM, Burton, Ross wrote:
> On 2 September 2014 11:54, Chen Qi <Qi.Chen@windriver.com> wrote:
>> The basic.target itself requires sysinit.target, so there's no
>> need to write this redundant line in the run-postinsts unit file.
>>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>> ---
>> meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts.service | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts.service b/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts.service
>> index 822327a..85a0439 100644
>> --- a/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts.service
>> +++ b/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts.service
>> @@ -13,5 +13,4 @@ RemainAfterExit=No
>> TimeoutSec=0
>>
>> [Install]
>> -WantedBy=basic.target
>> WantedBy=sysinit.target
> >From the commit message it sounds like you meant to remove
> sysinit.target. What is correct?
>
> Ross
>
>
Removing 'WantedBy=basic.target' is correct.
As sysinit.target is required by basic.target, and run-postinsts.service
is required by sysinit.target, then
run-postinsts.service has been in the dependency chain of basic.target.
So there's no need to write 'WantedBy=basic.target'.
Best Regards,
Chen Qi
next prev parent reply other threads:[~2014-09-03 2:50 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 10:53 [PATCH 00/26] systemd upgrade to 216 and other misc fixes Chen Qi
2014-09-02 10:53 ` [PATCH 01/26] systemd: upgrade to 216 Chen Qi
2014-09-04 19:30 ` Peter A. Bigot
2014-09-04 19:37 ` Burton, Ross
2014-09-05 10:21 ` Enrico Scholz
2014-09-08 17:02 ` Burton, Ross
2014-09-02 10:53 ` [PATCH 02/26] systemd: add PACKAGECONFIG for curl Chen Qi
2014-09-02 14:59 ` Burton, Ross
2014-09-03 2:38 ` ChenQi
2014-09-02 10:53 ` [PATCH 03/26] systemd: make runlevel work in non-runlevel targets Chen Qi
2014-09-02 10:53 ` [PATCH 04/26] update-rc.d: fix logic in populate_packages_updatercd Chen Qi
2014-09-02 10:53 ` [PATCH 05/26] alsa-state: fix pkg_postinst and set INHIBIT_UPDATERCD_BBCLASS Chen Qi
2014-09-02 10:53 ` [PATCH 06/26] keymaps: fix for systemd Chen Qi
2014-09-02 10:53 ` [PATCH 07/26] systemd: add kbd-keymaps to RRECOMMENDS of systemd-vconsole-setup Chen Qi
2014-09-02 10:53 ` [PATCH 08/26] v86d: set INHIBIT_UPDATERCD_BBCLASS if 'sysvinit' not in DISTRO_FEATURES Chen Qi
2014-09-02 10:53 ` [PATCH 09/26] systemd: add support for executing scripts under /etc/rcS.d Chen Qi
2014-09-02 15:00 ` Burton, Ross
2014-09-03 2:38 ` ChenQi
2014-09-02 10:53 ` [PATCH 10/26] dhcp: add dhcpd.service Chen Qi
2014-09-02 15:03 ` Burton, Ross
2014-09-03 2:39 ` ChenQi
2014-09-02 10:53 ` [PATCH 11/26] dhcp: add dhcrelay.service Chen Qi
2014-09-02 10:53 ` [PATCH 12/26] acpid: upgrade to 2.0.22 and add systemd support Chen Qi
2014-09-02 15:24 ` Burton, Ross
2014-09-03 2:39 ` ChenQi
2014-09-02 10:53 ` [PATCH 13/26] cups: make cups daemon start correctly Chen Qi
2014-09-02 15:36 ` Burton, Ross
2014-09-03 2:41 ` ChenQi
2014-09-02 10:54 ` [PATCH 14/26] cups: add systemd support Chen Qi
2014-09-02 15:38 ` Burton, Ross
2014-09-03 3:01 ` ChenQi
2014-09-02 10:54 ` [PATCH 15/26] rpcbind: avoid entering failed status after stopping daemon Chen Qi
2014-09-02 10:54 ` [PATCH 16/26] at: remove dependency on initscripts Chen Qi
2014-09-02 10:54 ` [PATCH 17/26] at: inherit update-rc.d to handle sysv init script Chen Qi
2014-09-02 10:54 ` [PATCH 18/26] keymaps: remove dependency on initscripts Chen Qi
2014-09-02 10:54 ` [PATCH 19/26] packagegroup-core-boot: conditionally rdepend on VIRTUAL-RUNTIME_initscripts Chen Qi
2014-09-02 10:54 ` [PATCH 20/26] initscripts: mask several init scripts Chen Qi
2014-09-02 10:54 ` [PATCH 21/26] keymaps: mask keymap when necessary Chen Qi
2014-09-02 10:54 ` [PATCH 22/26] v86d: mask fbsetup " Chen Qi
2014-09-02 10:54 ` [PATCH 23/26] psplash: mask psplash in case of systemd Chen Qi
2014-09-02 10:54 ` [PATCH 24/26] modutils-initscripts: mask modutils " Chen Qi
2014-09-02 10:54 ` [PATCH 25/26] run-postinsts.service: remove redundant line Chen Qi
2014-09-02 17:17 ` Burton, Ross
2014-09-03 2:50 ` ChenQi [this message]
2014-09-02 10:54 ` [PATCH 26/26] systemd: enable forwarding messages to syslog daemon Chen Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540681EE.9050602@windriver.com \
--to=qi.chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox