From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 698A3712AA for ; Tue, 9 Sep 2014 06:27:22 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.9/8.14.5) with ESMTP id s896RNdj019491 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for ; Mon, 8 Sep 2014 23:27:23 -0700 (PDT) Received: from [128.224.162.204] (128.224.162.204) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.174.1; Mon, 8 Sep 2014 23:27:23 -0700 Message-ID: <540E9DC8.9090708@windriver.com> Date: Tue, 9 Sep 2014 14:27:20 +0800 From: Chong Lu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: References: In-Reply-To: X-Originating-IP: [128.224.162.204] Subject: Re: [PATCH 2/2] perf: add libunwind support X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Sep 2014 06:27:24 -0000 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit ping On 08/29/2014 04:38 PM, Chong Lu wrote: > Add a new feature named 'perf-libunwind'. Adding this support to perf allows it > to do stack traces on ARM - thumb2 and MIPS targets. PERF_FEATURES variable in > perf-features.inc will enable the perf-libunwind. > > Signed-off-by: Chong Lu > --- > meta/recipes-kernel/perf/perf-features.inc | 2 +- > meta/recipes-kernel/perf/perf.bb | 5 ++++- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-kernel/perf/perf-features.inc b/meta/recipes-kernel/perf/perf-features.inc > index b8859ab..2dbbb47 100644 > --- a/meta/recipes-kernel/perf/perf-features.inc > +++ b/meta/recipes-kernel/perf/perf-features.inc > @@ -1,4 +1,4 @@ > -PERF_FEATURES_ENABLE ?= "perf-scripting perf-tui" > +PERF_FEATURES_ENABLE ?= "perf-scripting perf-tui perf-libunwind" > > def perf_feature_enabled(feature, trueval, falseval, d): > """ > diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb > index bfd210c..ab94a05 100644 > --- a/meta/recipes-kernel/perf/perf.bb > +++ b/meta/recipes-kernel/perf/perf.bb > @@ -20,6 +20,7 @@ BUILDPERF_libc-uclibc = "no" > # to cover a wide range of kernel we add both dependencies > TUI_DEPENDS = "${@perf_feature_enabled('perf-tui', 'libnewt slang', '',d)}" > SCRIPTING_DEPENDS = "${@perf_feature_enabled('perf-scripting', 'perl python', '',d)}" > +LIBUNWIND_DEPENDS = "${@perf_feature_enabled('perf-libunwind', 'libunwind', '',d)}" > > DEPENDS = "virtual/kernel \ > virtual/${MLPREFIX}libc \ > @@ -27,6 +28,7 @@ DEPENDS = "virtual/kernel \ > ${MLPREFIX}binutils \ > ${TUI_DEPENDS} \ > ${SCRIPTING_DEPENDS} \ > + ${LIBUNWIND_DEPENDS} \ > bison flex \ > " > > @@ -62,6 +64,7 @@ B = "${WORKDIR}/${BPN}-${PV}" > > SCRIPTING_DEFINES = "${@perf_feature_enabled('perf-scripting', '', 'NO_LIBPERL=1 NO_LIBPYTHON=1',d)}" > TUI_DEFINES = "${@perf_feature_enabled('perf-tui', '', 'NO_NEWT=1',d)}" > +LIBUNWIND_DEFINES = "${@perf_feature_enabled('perf-libunwind', '', 'NO_LIBUNWIND=1',d)}" > > # The LDFLAGS is required or some old kernels fails due missing > # symbols and this is preferred than requiring patches to every old > @@ -76,7 +79,7 @@ EXTRA_OEMAKE = '\ > CC="${CC}" \ > AR="${AR}" \ > perfexecdir=${libexecdir} \ > - NO_GTK2=1 ${TUI_DEFINES} NO_DWARF=1 NO_LIBUNWIND=1 ${SCRIPTING_DEFINES} \ > + NO_GTK2=1 ${TUI_DEFINES} NO_DWARF=1 ${LIBUNWIND_DEFINES} ${SCRIPTING_DEFINES} \ > ' > > EXTRA_OEMAKE += "\