Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Robert Yang <liezhi.yang@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] libxml2: fix python path and enable libxml2-python
Date: Mon, 15 Sep 2014 21:05:11 +0800	[thread overview]
Message-ID: <5416E407.4050703@windriver.com> (raw)
In-Reply-To: <CAJTo0LZx+PrHbn=2imh1gpFQF2fnHaUZ6xbMeO8bhvixnWWOsA@mail.gmail.com>


On 09/15/2014 06:43 AM, Burton, Ross wrote:
> On 9 September 2014 08:34, Robert Yang <liezhi.yang@windriver.com> wrote:
>> We have libxml2-python for native and nativesdk, but don't have it for
>> target, and can't find the reason from the git log, libxml2-python is
>> widely used, after looked into it's configure.in, we can enable it
>> easily.
>
> It seems like adding a PACKAGECONFIG for Python would be a good idea,
> we don't want to force target Python to be built.

Thanks, updated in the repo:

   git://git.openembedded.org/openembedded-core-contrib rbt/libxml2

commit ff4a9f5118f39d82fe1bb7fcc7870ef01a9cdb0b
Author: Robert Yang <liezhi.yang@windriver.com>
Date:   Mon Sep 8 20:24:38 2014 -0700

     libxml2: fix python path and add libxml2-python

     We have libxml2-python for native and nativesdk, but don't have it for
     target, and can't find the reason from the git log, libxml2-python is
     widely used, after looked into it's configure.in, we can add it
     by PACKAGECONFIG.

     The previous --with-python=${STAGING_BINDIR}/python is incorrect, it
     acted as work becase it's conigure can check automatically, python is in
     ${STAGING_BINDIR_NATIVE}/${PYTHON_PN}-native/${PYTHON_PN}, as known as
     ${PYTHON}.

     Signed-off-by: Robert Yang <liezhi.yang@windriver.com>

diff --git a/meta/recipes-core/libxml/libxml2.inc 
b/meta/recipes-core/libxml/libxml2.inc
index bcf9a62..4d11c2b 100644
--- a/meta/recipes-core/libxml/libxml2.inc
+++ b/meta/recipes-core/libxml/libxml2.inc
@@ -36,15 +36,14 @@ do_configure_prepend () {
         sed -i -e '/.*ansidecl.h.*/d' ${S}/configure.in
  }

-do_configure_prepend_class-nativesdk () {
-       # Ensure we get the correct site-packages path
-       export PYTHON_SITE_PACKAGES="${PYTHON_SITEPACKAGES_DIR}"
-}
+export PYTHON_SITE_PACKAGES="${PYTHON_SITEPACKAGES_DIR}"

+PACKAGECONFIG ??= ""
+PACKAGECONFIG[python] = 
"--with-python=${PYTHON},--without-python,python,python-core"
  # WARNING: zlib is require for RPM use
-EXTRA_OECONF = "--without-python --without-debug --without-legacy 
--with-catalog --without-docbook --with-c14n --without-lzma --with-fexceptions"
-EXTRA_OECONF_class-native = "--with-python=${STAGING_BINDIR}/python 
--without-legacy --without-docbook --with-c14n --without-lzma --with-zlib"
-EXTRA_OECONF_class-nativesdk = "--with-python=${STAGING_BINDIR}/python 
--without-legacy --without-docbook --with-c14n --without-lzma --with-zlib"
+EXTRA_OECONF = "--without-debug --without-legacy --with-catalog 
--without-docbook --with-c14n --without-lzma --with-fexceptions"
+EXTRA_OECONF_class-native = "--with-python=${PYTHON} --without-legacy 
--without-docbook --with-c14n --without-lzma --with-zlib"
+EXTRA_OECONF_class-nativesdk = "--with-python=${PYTHON} --without-legacy 
--without-docbook --with-c14n --without-lzma --with-zlib"
  EXTRA_OECONF_linuxstdbase = "--without-python --with-debug --with-legacy 
--with-docbook --with-c14n --without-lzma --with-zlib"

  # required for pythong binding

// Robert

>
> Ross
>
>


  reply	other threads:[~2014-09-15 13:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09  7:34 [PATCH 0/1] libxml2: fix python path and enable libxml2-python Robert Yang
2014-09-09  7:34 ` [PATCH 1/1] " Robert Yang
2014-09-14 22:43   ` Burton, Ross
2014-09-15 13:05     ` Robert Yang [this message]
2014-09-15 14:01       ` Burton, Ross
2014-09-15 14:38         ` Robert Yang
2014-09-15 14:43           ` Burton, Ross
2014-09-15 14:50             ` Robert Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5416E407.4050703@windriver.com \
    --to=liezhi.yang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox