Re: [PATCH 1/3] sstatesig: Only dump incremental locked signatures

[Hongxu Jia <hongxu.jia@windriver.com>]

On 09/18/2014 09:47 PM, Richard Purdie wrote:
> I'm afraid I'm starting to feel very strongly this is not a direction we
> should move in. Having the ability to write out a .inc file containing
> on a delta is one thing, writing out a file for automatic inclusion and
> trying to maintain that file is not something I feel comfortable with.
>
> I think that at some point there needs to be external tooling handling
> the inclusion and updating of this file and that the sigs code is not
> the place for this.
>
> For example, consider the case where you switch machines and want to
> share an include file between these machines. With the changes proposed
> in this patch series it will simply overwrite the file and remove the
> entries for the other machine.

Yes, you are right, it will overwrite, not for the locked sig file,
but the core structure self.lockedsigs

It could explain the necessary why I add 'type' to self.lockedsigs
in previous path series.
{pn:{task:{hash}}} --> {type:{pn:{task:{hash}}}}

//Hongxu

>
> We could keep trying to patch up this code to cover every combination
> and eventuality but in the end, I believe the maintenance of this file
> should be something external, the sigs code should only be concerned
> with the generation of the core entries.
>
> Cheers,
>
> Richard