Re: [OE-core] [PATCH v2] librsvg: add ptest support

[Gyorgy Sarvari <skandigraun@gmail.com>]

On 9/5/25 13:07, Mathieu Dubois-Briand wrote:
> On Thu Sep 4, 2025 at 1:21 PM CEST, Gyorgy Sarvari via lists.openembedded.org wrote:
>> The suite is quick, it takes ~5 seconds on my machine to execute.
>>
>> The tests consist of 2 or 3 parts, depending on how one counts them.
>>
>> The apitest PACKAGACONFIG compiles tests for the c-interface, as part of
>> the main meson build. This apitest expects test data to be present in
>> a folder relative the test binary: ../../rsvg/tests folder.
>>
>> ptest-cargo compiles two sets of test: rsvg-convert tests, and generic assorted
>> tests for the library, in multiple binaries.
>>
>> The rsvg-convert tests expect test data to be present in a "tests" folder,
>> in the same folder where the test binaries are.
>>
>> The library tests expect the tests to be in a folder called "tests", that's
>> location is specified by the CARGO_MANIFEST_DIR environment variable.
>>
>> As part of compiling the cargo tests, rsvg-convert is also compiled specifically
>> for the tests, however it is not supposed to be different from the actual binary.
>> It is deleted from the test set, because of two reasons:
>> 1. It is not bit-identical to the actually installed rsvg-convert (it is compiled differently,
>>    with cargo only, without meson)
>> 2. ptest-cargo class treated it as a test binary, and tried to execute it, which resulted
>>    in failing/hanging test.
>>
>> It is avoided by not installing this binary, but rather use the real rsvg package
>> as a runtime dependency, and create a symlink to it in the run-ptest script.
>>
>> Added liberation-fonts as a runtime dependency to the tests - the rsvg-convert
>> tests require some fonts to be available to be able to render during some
>> svg->pdf conversion tests.
>>
>> Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com>
>> ---
> Hi Gyorgy,
>
> Thanks for your patch.
>
> I believe we see two issues on the autobuilder.
>
> First, we do have a reproducibility error:
>
> AssertionError: The following deb packages are different and not in exclusion list:
> /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/deb/./x86-64-v3/librsvg-2-ptest_2.61.0-r0_amd64.deb
> The following ipk packages are different and not in exclusion list:
> /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/ipk/./x86-64-v3/librsvg-2-ptest_2.61.0-r0_x86-64-v3.ipk
> The following rpm packages are different and not in exclusion list:
> /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/rpm/./x86_64_v3/librsvg-2-ptest-2.61.0-r0.x86_64_v3.rpm
>
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/37/builds/2422
> https://valkyrie.yocto.io/pub/repro-fail/oe-reproducible-20250905-lgqh2ddp/packages/diff-html/
>
> Also, there is some build error. This one only appears on some platforms
> and seems a bit intermittent.
>
> ERROR: librsvg-2.61.0-r0 do_configure: Execution of '/srv/pokybuild/yocto-worker/qemuarm64-ptest/build/build/tmp/work/cortexa57-poky-linux/librsvg/2.61.0/temp/run.do_configure.3967314' failed with exit code 1
> ...
> | ../sources/librsvg-2.61.0/meson.build:357:4: ERROR: Problem encountered: error: error loading target specification: could not find specification for target "aarch64-poky-linux-gnu"
>
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/61/builds/2191
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/23/builds/2417
>
> Can you have a look, please?

The reproducibility issue should be fixed by [1], and [2] should take
care of the intermittent build failure - both of them are in master now.
Could you please retry this librsvg patch?

[1]: https://lists.openembedded.org/g/openembedded-core/message/223009
[2]: https://lists.openembedded.org/g/openembedded-core/message/223039