From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id 2C09B6A362 for ; Mon, 13 Oct 2014 09:04:44 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.14.9/8.14.5) with ESMTP id s9D94fVb015515 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for ; Mon, 13 Oct 2014 02:04:45 -0700 (PDT) Received: from [128.224.162.187] (128.224.162.187) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.174.1; Mon, 13 Oct 2014 02:04:41 -0700 Message-ID: <543B95F0.8010707@windriver.com> Date: Mon, 13 Oct 2014 17:05:52 +0800 From: ChenQi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: References: <1407488988-14910-1-git-send-email-sujith.h@gmail.com> <53E511E2.10300@linux.intel.com> In-Reply-To: X-Originating-IP: [128.224.162.187] Subject: Re: [PATCH] psplash: Adding support for systemd service files X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Oct 2014 09:04:47 -0000 Content-Type: multipart/alternative; boundary="------------000009050202010307050500" --------------000009050202010307050500 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Does anybody know what's the current state of this issue? Thanks, Chen Qi On 08/11/2014 06:00 PM, sujith h wrote: > > > > On Fri, Aug 8, 2014 at 11:37 PM, Saul Wold > wrote: > > On 08/08/2014 02:09 AM, Sujith H wrote: > > From: Sujith H > > > If the DISTRO_FEATURES has systemd, then its better > to have corresponding service files associated with > the psplash. This change will help to do the same. > > Can you propose a patch to the psplash upstream which is part of > the Yocto Project (send the patch to yocto@yoctoproject.org > ) and then we can do a psplash > upgrade to include these files directly? > > > Ok then I will submit the same patch to Yocto Project. > > Thanks, > Sujith H > > > Thanks > Sau! > > > Signed-off-by: Muzaffar Mahmood > > Signed-off-by: Sujith H > > --- > meta/recipes-core/psplash/files/psplash-quit.service | 11 > +++++++++++ > meta/recipes-core/psplash/files/psplash-start.service | 11 > +++++++++++ > meta/recipes-core/psplash/psplash_git.bb > | 12 +++++++++++- > 3 files changed, 33 insertions(+), 1 deletion(-) > create mode 100644 > meta/recipes-core/psplash/files/psplash-quit.service > create mode 100644 > meta/recipes-core/psplash/files/psplash-start.service > > diff --git > a/meta/recipes-core/psplash/files/psplash-quit.service > b/meta/recipes-core/psplash/files/psplash-quit.service > new file mode 100644 > index 0000000..14bd499 > --- /dev/null > +++ b/meta/recipes-core/psplash/files/psplash-quit.service > @@ -0,0 +1,11 @@ > +[Unit] > +Description=Terminate Psplash Boot Screen > +After=psplash-start.service > + > +[Service] > +Type=oneshot > +ExecStart=/usr/bin/psplash-write QUIT > +TimeoutSec=20 > + > +[Install] > +WantedBy=multi-user.target > diff --git > a/meta/recipes-core/psplash/files/psplash-start.service > b/meta/recipes-core/psplash/files/psplash-start.service > new file mode 100644 > index 0000000..502b150 > --- /dev/null > +++ b/meta/recipes-core/psplash/files/psplash-start.service > @@ -0,0 +1,11 @@ > +[Unit] > +Description=Starts Psplash Boot screen > +Wants=systemd-vconsole-setup.service > +After=systemd-vconsole-setup.service > systemd-udev-trigger.service systemd-udevd.service > +DefaultDependencies=no > + > +[Service] > +ExecStart=/usr/bin/psplash > + > +[Install] > +WantedBy=sysinit.target > diff --git a/meta/recipes-core/psplash/psplash_git.bb > > b/meta/recipes-core/psplash/psplash_git.bb > index 628ced4..16fa0ae 100644 > --- a/meta/recipes-core/psplash/psplash_git.bb > > +++ b/meta/recipes-core/psplash/psplash_git.bb > > @@ -11,6 +11,8 @@ PR = "r15" > > SRC_URI = "git://git.yoctoproject.org/${BPN} > \ > file://psplash-init \ > + file://psplash-start.service \ > + file://psplash-quit.service \ > ${SPLASH_IMAGES}" > > SPLASH_IMAGES = "file://psplash-poky-img.h;outsuffix=default" > @@ -65,11 +67,14 @@ python __anonymous() { > > S = "${WORKDIR}/git" > > -inherit autotools pkgconfig update-rc.d update-alternatives > +inherit autotools pkgconfig update-rc.d update-alternatives > systemd > > ALTERNATIVE_PRIORITY = "100" > ALTERNATIVE_LINK_NAME[psplash] = "${bindir}/psplash" > > +SYSTEMD_PACKAGES = > "${@base_contains('DISTRO_FEATURES','systemd','${PN}','',d)}" > +SYSTEMD_SERVICE_${PN} = > "${@base_contains('DISTRO_FEATURES','systemd','psplash-start.service > psplash-quit.service','',d)}" > + > python do_compile () { > import shutil > > @@ -103,6 +108,11 @@ do_install_append() { > install -m 0755 $i ${D}${bindir}/$i > done > rm -f ${D}${bindir}/psplash > + > + if > ${@base_contains('DISTRO_FEATURES','systemd','true','false',d)}; > then > + install -d ${D}${systemd_unitdir}/system > + install -m 644 ${WORKDIR}/*.service > ${D}/${systemd_unitdir}/system > + fi > } > > FILES_${PN} += "/mnt/.psplash" > > > > > -- > സുജിത് ഹരിദാസന് > Bangalore > Contributor to KDE project > http://fci.wikia.com/wiki/Anti-DRM-Campaign > http://sujithh.info > > --------------000009050202010307050500 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit
Does anybody know what's the current state of this issue?

Thanks,
Chen Qi

On 08/11/2014 06:00 PM, sujith h wrote:



On Fri, Aug 8, 2014 at 11:37 PM, Saul Wold <sgw@linux.intel.com> wrote:
On 08/08/2014 02:09 AM, Sujith H wrote:
From: Sujith H <Sujith_Haridasan@mentor.com>

If the DISTRO_FEATURES has systemd, then its better
to have corresponding service files associated with
the psplash. This change will help to do the same.

Can you propose a patch to the psplash upstream which is part of the Yocto Project (send the patch to yocto@yoctoproject.org) and then we can do a psplash upgrade to include these files directly?

Ok then I will submit the same patch to Yocto Project.

Thanks,
Sujith H

Thanks
        Sau!


Signed-off-by: Muzaffar Mahmood <muzaffar_mahmood@mentor.com>
Signed-off-by: Sujith H <Sujith_Haridasan@mentor.com>
---
  meta/recipes-core/psplash/files/psplash-quit.service  | 11 +++++++++++
  meta/recipes-core/psplash/files/psplash-start.service | 11 +++++++++++
  meta/recipes-core/psplash/psplash_git.bb              | 12 +++++++++++-
  3 files changed, 33 insertions(+), 1 deletion(-)
  create mode 100644 meta/recipes-core/psplash/files/psplash-quit.service
  create mode 100644 meta/recipes-core/psplash/files/psplash-start.service

diff --git a/meta/recipes-core/psplash/files/psplash-quit.service b/meta/recipes-core/psplash/files/psplash-quit.service
new file mode 100644
index 0000000..14bd499
--- /dev/null
+++ b/meta/recipes-core/psplash/files/psplash-quit.service
@@ -0,0 +1,11 @@
+[Unit]
+Description=Terminate Psplash Boot Screen
+After=psplash-start.service
+
+[Service]
+Type=oneshot
+ExecStart=/usr/bin/psplash-write QUIT
+TimeoutSec=20
+
+[Install]
+WantedBy=multi-user.target
diff --git a/meta/recipes-core/psplash/files/psplash-start.service b/meta/recipes-core/psplash/files/psplash-start.service
new file mode 100644
index 0000000..502b150
--- /dev/null
+++ b/meta/recipes-core/psplash/files/psplash-start.service
@@ -0,0 +1,11 @@
+[Unit]
+Description=Starts Psplash Boot screen
+Wants=systemd-vconsole-setup.service
+After=systemd-vconsole-setup.service systemd-udev-trigger.service systemd-udevd.service
+DefaultDependencies=no
+
+[Service]
+ExecStart=/usr/bin/psplash
+
+[Install]
+WantedBy=sysinit.target
diff --git a/meta/recipes-core/psplash/psplash_git.bb b/meta/recipes-core/psplash/psplash_git.bb
index 628ced4..16fa0ae 100644
--- a/meta/recipes-core/psplash/psplash_git.bb
+++ b/meta/recipes-core/psplash/psplash_git.bb
@@ -11,6 +11,8 @@ PR = "r15"

  SRC_URI = "git://git.yoctoproject.org/${BPN} \
             file://psplash-init \
+           file://psplash-start.service \
+           file://psplash-quit.service \
             ${SPLASH_IMAGES}"

  SPLASH_IMAGES = "file://psplash-poky-img.h;outsuffix=default"
@@ -65,11 +67,14 @@ python __anonymous() {

  S = "${WORKDIR}/git"

-inherit autotools pkgconfig update-rc.d update-alternatives
+inherit autotools pkgconfig update-rc.d update-alternatives systemd

  ALTERNATIVE_PRIORITY = "100"
  ALTERNATIVE_LINK_NAME[psplash] = "${bindir}/psplash"

+SYSTEMD_PACKAGES = "${@base_contains('DISTRO_FEATURES','systemd','${PN}','',d)}"
+SYSTEMD_SERVICE_${PN} = "${@base_contains('DISTRO_FEATURES','systemd','psplash-start.service psplash-quit.service','',d)}"
+
  python do_compile () {
      import shutil

@@ -103,6 +108,11 @@ do_install_append() {
                install -m 0755 $i ${D}${bindir}/$i
        done
        rm -f ${D}${bindir}/psplash
+
+       if ${@base_contains('DISTRO_FEATURES','systemd','true','false',d)}; then
+                install -d ${D}${systemd_unitdir}/system
+                install -m 644 ${WORKDIR}/*.service ${D}/${systemd_unitdir}/system
+        fi
  }

  FILES_${PN} += "/mnt/.psplash"




--
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info



--------------000009050202010307050500--