Re: [PATCH V2] opkg: Call prerm and postrm scripts on package upgrade.

[Peter Urbanec <openembedded-devel@urbanec.net>]

On 16/10/14 04:26, Paul Barker wrote:
> For the sake of future readers within OpenEmbedded, we need to make
> clearer here that this is opkg issue 104, not an OE issue number. This
> change isn't needed in the patch to opkg upstream though.
>
>> +
>> +Signed-off-by: Peter Urbanec <openembedded-devel@urbanec.net>
>
> Sorry to be pedantic but there's now 2 copies of the Signed-off-by
> line. If you resend this, I'd also bring the Upstream-status line down
> so that it immediately follows the Signed-off-by line. That's just a
> minor cosmetic point though, it may be possible for someone to make
> these edits as the patch is merged.

I resent the patch with your suggestions incorporated. Specifically, I 
mentioned that the patch is for an opkg issue and provided the URL to 
the relevant opkg issue tracker entry. I also rearranged the 
Upstream-Status and Signed-off-by lines as suggested.

> This looks fine. As I've said in reply to the patch on the opkg-devel
> mailing list, I'm busy this week but should have time to test this
> properly next week. It looks correct to me though, the logic is almost
> identical to the patch I prepared which covers prerm only.
>
> It probably doesn't need to wait for my test before going into OE though.

Thanks. Version 3 of the patch I sent out has no code changes, just the 
patch meta information and comments.

Cheers,

	Peter