From: Andreas Oberritter <obi@opendreambox.org>
To: Paul Barker <paul@paulbarker.me.uk>,
"Burton, Ross" <ross.burton@intel.com>
Cc: Peter Urbanec <openembedded-devel@urbanec.net>,
OE Core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH V3] opkg: Call prerm and postrm scripts on package upgrade.
Date: Fri, 24 Oct 2014 14:01:05 +0200 [thread overview]
Message-ID: <544A3F81.7050508@opendreambox.org> (raw)
In-Reply-To: <CANyK_8dA9inDGDhDhb6TcZ-AbTHD5NbCJ-zB6e8m-H+TW2XFHw@mail.gmail.com>
On 24.10.2014 12:49, Paul Barker wrote:
> On 22 October 2014 23:54, Burton, Ross <ross.burton@intel.com> wrote:
>>
>> On 21 October 2014 16:40, Paul Barker <paul@paulbarker.me.uk> wrote:
>>>
>>> Sorry Peter, it looks like this patch has been corrupted as well as
>>> the one sent to the opkg-devel list. In this case I think it's mostly
>>> lines like the above which have been incorrectly wrapped.
>>>
>>> Could you resend this using 'git send-email' if possible?
>>
>>
>> Alternatively (and preferably for large numbers of patches), push your
>> changes to a git repo somewhere.
>>
>> Ross
>
> This patch can now be marked as a backport if it is resent.
>
> I'd probably say it shouldn't be applied in oe-core until after the
> 1.7 branch now as it's so close to release and if any prerm/postrm
> scripts don't check for an "upgrade" argument they may end up doing
> the wrong thing.
>
> Cheers,
>
As already pointed out in the discussion about the other patch ("Better
support for upgrading packages in opkg and update-rc.d.bbclass"),
OE-Core expects prerm and postrm scripts not to run on upgrade. Not only
with opkg, but with rpm and apt/dpkg, too. So unless we're going to
accept breaking virtually every prerm and postrm script in the OE-Core
ecosystem, somebody will need to come up with a good plan before
applying this patch, even after the release.
FWIW, it would be safe to apply if preceded by a patch making
package_ipk.bbclass inject code to skip these scripts upgrades as rpm
and deb do, effectively turning this patch into a no-op, but bringing
all package managers in line before any further changes.
Regards,
Andreas
next prev parent reply other threads:[~2014-10-24 12:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <543ef52e.0879c20a.1785.4076SMTPIN_ADDED_BROKEN@mx.google.com>
2014-10-21 15:40 ` [PATCH V3] opkg: Call prerm and postrm scripts on package upgrade Paul Barker
2014-10-22 22:54 ` Burton, Ross
2014-10-24 10:49 ` Paul Barker
2014-10-24 12:01 ` Andreas Oberritter [this message]
2014-10-15 22:27 Peter Urbanec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544A3F81.7050508@opendreambox.org \
--to=obi@opendreambox.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=openembedded-devel@urbanec.net \
--cc=paul@paulbarker.me.uk \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox