From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id E369F713A5 for ; Thu, 13 Nov 2014 08:04:14 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.14.9/8.14.5) with ESMTP id sAD84EkY023239 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 13 Nov 2014 00:04:14 -0800 (PST) Received: from [128.224.162.187] (128.224.162.187) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.174.1; Thu, 13 Nov 2014 00:04:14 -0800 Message-ID: <54646673.3020702@windriver.com> Date: Thu, 13 Nov 2014 16:06:11 +0800 From: ChenQi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: "Burton, Ross" References: In-Reply-To: X-Originating-IP: [128.224.162.187] Cc: OE-core Subject: Re: [PATCH 1/1] systemd: add option for valgrind header checking X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Nov 2014 08:04:15 -0000 Content-Type: multipart/alternative; boundary="------------060104020207060108010009" --------------060104020207060108010009 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit On 11/12/2014 11:55 PM, Burton, Ross wrote: > On 12 November 2014 10:45, Chen Qi > wrote: > > +-AC_CHECK_HEADERS_ONCE([valgrind/memcheck.h valgrind/valgrind.h]) > ++AC_ARG_ENABLE(valgrindheader, > AS_HELP_STRING([--disable-valgrindheader], [disable valgrind > header checking])) > ++if test "x$enable_valgrindheader" != "xno"; then > ++ AC_CHECK_HEADERS_ONCE([valgrind/memcheck.h > valgrind/valgrind.h]) > ++fi > > > If the user passes --enable-valgrindheader and valgrind isn't present, > it doesn't fail. Combined with the lack of a valgrind build > dependency in the PACKAGECONFIG statement this isn't a very useful > PACKAGECONFIG option as it only works when not specified, and if it's > specified is non-deterministic. > Hi Ross, I've sent to V2 with modification in PACKAGECONFIG. With this modification, the build result would not be non-deterministic. Best Regards, Chen Qi > It appears that this valgrind support is for running the test suite > under valgrind for leak detection, which is something we're unlikely > to do. A quick fix would be to comment out the check. > > A proper fix would be to use AC_ARG_WITH(valgrind), default to "auto", > use the pkg-config macros and respect yes/no/auto as appropriate. The > mantra here being to spend ten minutes fixing it properly upstream > instead of having to rewrite the patch often as upstream changes their > configure script. > > Ross --------------060104020207060108010009 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
On 11/12/2014 11:55 PM, Burton, Ross wrote:
On 12 November 2014 10:45, Chen Qi <Qi.Chen@windriver.com> wrote:
+-AC_CHECK_HEADERS_ONCE([valgrind/memcheck.h valgrind/valgrind.h])
++AC_ARG_ENABLE(valgrindheader, AS_HELP_STRING([--disable-valgrindheader], [disable valgrind header checking]))
++if test "x$enable_valgrindheader" != "xno"; then
++        AC_CHECK_HEADERS_ONCE([valgrind/memcheck.h valgrind/valgrind.h])
++fi

If the user passes --enable-valgrindheader and valgrind isn't present, it doesn't fail.  Combined with the lack of a valgrind build dependency in the PACKAGECONFIG statement this isn't a very useful PACKAGECONFIG option as it only works when not specified, and if it's specified is non-deterministic.


Hi Ross,

I've sent to V2 with modification in PACKAGECONFIG. With this modification, the build result would not be non-deterministic.

Best Regards,
Chen Qi

It appears that this valgrind support is for running the test suite under valgrind for leak detection, which is something we're unlikely to do.  A quick fix would be to comment out the check.

A proper fix would be to use AC_ARG_WITH(valgrind), default to "auto", use the pkg-config macros and respect yes/no/auto as appropriate.  The mantra here being to spend ten minutes fixing it properly upstream instead of having to rewrite the patch often as upstream changes their configure script.

Ross

--------------060104020207060108010009--